From 0bdd0d18e1b4c67b00fe08442e539e6f0ddefb6f Mon Sep 17 00:00:00 2001 From: vnmedeiros Date: Sun, 28 Jul 2024 12:36:42 -0300 Subject: [PATCH] fix: adjust test case and check if order is defined --- .../api/endpoints/class-tainacan-rest-items-controller.php | 2 +- tests/test-api-items.php | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/classes/api/endpoints/class-tainacan-rest-items-controller.php b/src/classes/api/endpoints/class-tainacan-rest-items-controller.php index 197ba551d..b4c73a3bc 100644 --- a/src/classes/api/endpoints/class-tainacan-rest-items-controller.php +++ b/src/classes/api/endpoints/class-tainacan-rest-items-controller.php @@ -540,7 +540,7 @@ class REST_Items_Controller extends REST_Controller { ); $filter_id = empty($filter) ? false : $filter[0]->get_id(); - $filter_order_index = array_search( $filter_id, array_column( $order, 'id' ) ); + $filter_order_index = $order ? array_search( $filter_id, array_column( $order, 'id' ) ) : false; if ( !empty($filter_order_index) && $order[$filter_order_index]['enabled'] == true) { $f = $filter[0]->_toArray(); $filter_type_component = $filter[0]->get_filter_type_object()->get_component(); diff --git a/tests/test-api-items.php b/tests/test-api-items.php index 9a65ba913..22ad3d019 100644 --- a/tests/test-api-items.php +++ b/tests/test-api-items.php @@ -114,7 +114,7 @@ class TAINACAN_REST_Items_Controller extends TAINACAN_UnitApiTestCase { $data = $response->get_data(); - $this->assertEquals($item1->get_title(), $data['title']); + $this->assertEquals($item1->get_id(), $data['id']); $post_meta = get_post_meta($item1->get_id(), '_wp_trash_meta_status', true); @@ -147,7 +147,7 @@ class TAINACAN_REST_Items_Controller extends TAINACAN_UnitApiTestCase { $data = $response->get_data(); - $this->assertEquals($item2->get_title(), $data['title']); + $this->assertEquals($item2->get_id(), $data['id']); $no_post = get_post($item2->get_id());