tmdinosaurcenter
/
tainacan
mirror of https://github.com/tainacan/tainacan
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Change response of create bulk edit group endpoint #69 #139

This commit is contained in:
leogermani 2018-10-04 16:52:53 -03:00
parent 43f8118b80
commit 126b6e1d29
2 changed files with 16 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/api/endpoints/class-tainacan-rest-bulkedit-controller.php
View File

@ -224,14 +224,10 @@ class REST_Bulkedit_Controller extends REST_Controller {
$bulk = new \Tainacan\Bulk_Edit($args); $bulk = new \Tainacan\Bulk_Edit($args);
$response = [ $response = $this->prepare_item_for_response($bulk, $request);
'id' => $bulk->get_id()
];
$rest_response = new \WP_REST_Response($response, 200); $rest_response = new \WP_REST_Response($response, 200);
$rest_response->header('X-WP-Total', $bulk->count_posts());
return $rest_response; return $rest_response;
} }
@ -291,23 +287,31 @@ class REST_Bulkedit_Controller extends REST_Controller {
$bulk = new \Tainacan\Bulk_Edit($args); $bulk = new \Tainacan\Bulk_Edit($args);
$count = $bulk->count_posts(); $return = $this->prepare_item_for_response($bulk, $request);
if (0 === $count) { if (0 === $return['items_count']) {
return new \WP_REST_Response([ return new \WP_REST_Response([
'error_message' => __('Group not found', 'tainacan'), 'error_message' => __('Group not found', 'tainacan'),
], 404); ], 404);
} }
$options = $bulk->get_options(); return new \WP_REST_Response($return, 200);
}
function prepare_item_for_response($bulk_object, $request) {
$count = $bulk_object->count_posts();
$options = $bulk_object->get_options();
$return = [ $return = [
'id' => $group_id, 'id' => $bulk_object->get_id(),
'items_count' => $count, 'items_count' => $count,
'options' => $options 'options' => $options
]; ];
return new \WP_REST_Response($return, 200); return $return;
} }
public function trash_items($request) { public function trash_items($request) {

4
tests/test-bulkedit.php
View File

@ -914,7 +914,7 @@ class BulkEdit extends TAINACAN_UnitApiTestCase {
$this->assertTrue(is_string($data['id'])); $this->assertTrue(is_string($data['id']));
$this->assertEquals(17, $response->headers['X-WP-Total']); $this->assertEquals(17, $data['items_count']);
} }
@ -962,7 +962,7 @@ class BulkEdit extends TAINACAN_UnitApiTestCase {
$this->assertTrue(is_string($data['id'])); $this->assertTrue(is_string($data['id']));
$this->assertEquals(20, $response->headers['X-WP-Total']); $this->assertEquals(20, $data['items_count']);
} }