From 8b589ff32ea3d05fc8a526aefbd020077ac221e9 Mon Sep 17 00:00:00 2001
From: mateuswetah <mateus.m.luna@gmail.com>
Date: Wed, 6 May 2020 17:08:47 -0300
Subject: [PATCH 1/4] Fixes some string noticed on translation.

---
 .../gutenberg-blocks/tainacan-facets/faceted-search/index.js  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/views/gutenberg-blocks/tainacan-facets/faceted-search/index.js b/src/views/gutenberg-blocks/tainacan-facets/faceted-search/index.js
index 9983da8fa..dd41a058d 100644
--- a/src/views/gutenberg-blocks/tainacan-facets/faceted-search/index.js
+++ b/src/views/gutenberg-blocks/tainacan-facets/faceted-search/index.js
@@ -483,7 +483,7 @@ registerBlockType('tainacan/faceted-search', {
                             />
                             <ToggleControl
                                 label={__('Start with Filters hidden', 'tainacan')}
-                                help={ startWithFiltersHidden ? __('Render the list with filters hidden at first" button', 'tainacan') : __('Toggle to render the list with filters visible at first', 'tainacan')}
+                                help={ startWithFiltersHidden ? __('Render the list with filters hidden at first', 'tainacan') : __('Toggle to render the list with filters visible at first', 'tainacan')}
                                 checked={ startWithFiltersHidden }
                                 onChange={ ( isChecked ) => {
                                         startWithFiltersHidden = isChecked;
@@ -493,7 +493,7 @@ registerBlockType('tainacan/faceted-search', {
                             />
                             <ToggleControl
                                 label={__('Filters as a Modal', 'tainacan')}
-                                help={ filtersAsModal ? __('Render the filters area as modal instead of a collapse" button', 'tainacan') : __('Toggle to show filters list as a collapse instead of a modal', 'tainacan')}
+                                help={ filtersAsModal ? __('Render the filters area as modal instead of a side panel" button', 'tainacan') : __('Toggle to show filters list as a side panel instead of a modal', 'tainacan')}
                                 checked={ filtersAsModal }
                                 onChange={ ( isChecked ) => {
                                         filtersAsModal = isChecked;

From b48a5695487f3a2d73f4564100ed80477be84cd8 Mon Sep 17 00:00:00 2001
From: mateuswetah <mateus.m.luna@gmail.com>
Date: Wed, 6 May 2020 17:39:59 -0300
Subject: [PATCH 2/4] More string values updates.

---
 .../metadata-types/compound/class-tainacan-compound.php         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/views/admin/components/metadata-types/compound/class-tainacan-compound.php b/src/views/admin/components/metadata-types/compound/class-tainacan-compound.php
index 0c3cbd513..54df8f5af 100644
--- a/src/views/admin/components/metadata-types/compound/class-tainacan-compound.php
+++ b/src/views/admin/components/metadata-types/compound/class-tainacan-compound.php
@@ -16,7 +16,7 @@ class Compound extends Metadata_Type {
 		// call metadatum type constructor
 		parent::__construct();
 		$this->set_name( __('Compound', 'tainacan') );
-		$this->set_description( __('A compound metadata can have different types with groups of values.', 'tainacan') );
+		$this->set_description( __('A compound metadatum can have groups of values of different types.', 'tainacan') );
 		$this->set_primitive_type('compound');
 		$this->set_component('tainacan-compound');
 		$this->set_form_component('tainacan-form-compound');

From 857d89471b4df8cf0f92f529b322e20083dfed79 Mon Sep 17 00:00:00 2001
From: mateuswetah <mateus.m.luna@gmail.com>
Date: Wed, 6 May 2020 17:49:36 -0300
Subject: [PATCH 3/4] Mooore string values update.

---
 .../endpoints/class-tainacan-rest-item-metadata-controller.php  | 2 +-
 .../class-tainacan-bulk-edit-process.php                        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/classes/api/endpoints/class-tainacan-rest-item-metadata-controller.php b/src/classes/api/endpoints/class-tainacan-rest-item-metadata-controller.php
index fc566d12f..cd4b1f926 100644
--- a/src/classes/api/endpoints/class-tainacan-rest-item-metadata-controller.php
+++ b/src/classes/api/endpoints/class-tainacan-rest-item-metadata-controller.php
@@ -291,7 +291,7 @@ class REST_Item_Metadata_Controller extends REST_Controller {
 			$endpoint_args['parent_meta_id'] = [
 				'type'        => 'array/string/object/integer',
 				'items'       => ['type' => 'array/string/object/integer'],
-				'description' => __('The parent meta ID for group children item metadatas')
+				'description' => __('The parent meta ID for the item metadata children group')
 			];
 		}
 
diff --git a/src/classes/generic-background-process/class-tainacan-bulk-edit-process.php b/src/classes/generic-background-process/class-tainacan-bulk-edit-process.php
index 9666eb58b..e72008e2a 100644
--- a/src/classes/generic-background-process/class-tainacan-bulk-edit-process.php
+++ b/src/classes/generic-background-process/class-tainacan-bulk-edit-process.php
@@ -325,7 +325,7 @@ class Bulk_Edit_Process extends Generic_Process {
 			}
 		}
 		
-		$this->add_error_log( __('Not possible to copy permission for different types', 'tainacan') );
+		$this->add_error_log( __('Not possible to copy metadata values of different types', 'tainacan') );
 		return false;
 	}
 

From 4f28e42980212c99b4ea96411f130e64899f1e66 Mon Sep 17 00:00:00 2001
From: mateuswetah <mateus.m.luna@gmail.com>
Date: Thu, 7 May 2020 12:57:01 -0300
Subject: [PATCH 4/4] Uses value update to compound metadata endpoint to
 retrieve parent_meta_id of new groups

---
 .../metadata-types/compound/Compound.vue      | 60 +++++++++++--------
 src/views/admin/js/event-bus-item-metadata.js |  3 +
 .../admin/js/store/modules/item/actions.js    | 21 +++++++
 3 files changed, 58 insertions(+), 26 deletions(-)

diff --git a/src/views/admin/components/metadata-types/compound/Compound.vue b/src/views/admin/components/metadata-types/compound/Compound.vue
index 8ad3280f8..8441e3c8b 100644
--- a/src/views/admin/components/metadata-types/compound/Compound.vue
+++ b/src/views/admin/components/metadata-types/compound/Compound.vue
@@ -84,7 +84,10 @@
         <span class="icon is-small">
             <i class="tainacan-icon has-text-secondary tainacan-icon-add"/>
         </span>
-        &nbsp;{{ $i18n.get('label_add_value') }}
+        &nbsp;{{ $i18n.get('label_add_value') }}&nbsp;
+        <span class="icon">
+            <i class="tainacan-icon has-text-secondary tainacan-icon-loading"/>
+        </span>
     </a>
 
 </div>
@@ -102,6 +105,7 @@
         data() {
             return {
                 isRemovingGroup: false,
+                isCreatingGroup: false,
                 children: [],
                 collapseAllChildren: true,
                 childItemMetadataGroups: []
@@ -226,34 +230,38 @@
                 this.childItemMetadataGroups[groupIndex][index].collapse = !event;
             },
             addGroup() {
-                // Create a new placeholder parent_meta_id group here.
-                let newEmptyGroup = [];
-
-                if (this.itemMetadatum &&
-                    this.itemMetadatum.metadatum &&
-                    this.itemMetadatum.metadatum.metadata_type_options &&
-                    this.itemMetadatum.metadatum.metadata_type_options.children_objects.length > 0 
-                ) {
-                    for (let child of this.itemMetadatum.metadatum.metadata_type_options.children_objects) {
-                        let childObject = {
-                            item: this.itemMetadatum.item,
-                            metadatum: child,
-                            parent_meta_id: 0,
-                            value: '',
-                            value_as_html: '',
-                            value_as_string: '',
-                            collapse: false
-                        };
-                        newEmptyGroup.push(childObject)
-                    }
-                }
 
+                this.isCreatingGroup = true;
+                
                 // Sends value to api so we can obtain the parent_meta_id
-                eventBusItemMetadata.$emit('input', {
+                eventBusItemMetadata.fetchCompoundFirstParentMetaId({
                     itemId: this.itemMetadatum.item.id,
-                    metadatumId: newEmptyGroup[0].metadatum.id,
-                    values: newEmptyGroup[0].value,
-                    parentMetaId: newEmptyGroup[0].parent_meta_id
+                    metadatumId: this.itemMetadatum.metadatum.id
+                }).then((parentMetaId) => {
+
+                    // Create a new placeholder parent_meta_id group here.
+                    let newEmptyGroup = [];
+
+                    if (this.itemMetadatum &&
+                        this.itemMetadatum.metadatum &&
+                        this.itemMetadatum.metadatum.metadata_type_options &&
+                        this.itemMetadatum.metadatum.metadata_type_options.children_objects.length > 0 
+                    ) {
+                        for (let child of this.itemMetadatum.metadatum.metadata_type_options.children_objects) {
+                            let childObject = {
+                                item: this.itemMetadatum.item,
+                                metadatum: child,
+                                parent_meta_id: parentMetaId,
+                                value: '',
+                                value_as_html: '',
+                                value_as_string: '',
+                                collapse: false
+                            };
+                            newEmptyGroup.push(childObject)
+                        }
+                    }   
+                    
+                    this.isCreatingGroup = true;
                 });
             },
             removeGroup(groupIndex) {   
diff --git a/src/views/admin/js/event-bus-item-metadata.js b/src/views/admin/js/event-bus-item-metadata.js
index a4302e7b6..b54bf137f 100644
--- a/src/views/admin/js/event-bus-item-metadata.js
+++ b/src/views/admin/js/event-bus-item-metadata.js
@@ -87,6 +87,9 @@ export const eventBusItemMetadata = new Vue({
         },
         clearAllErrors() {
            this.errors = [];
+        },
+        fetchCompoundFirstParentMetaId({ itemId, metadatumId }) {
+            return this.$store.dispatch('item/fetchCompoundFirstParentMetaId', { item_id: itemId, metadatum_id: metadatumId });
         }
     }
 });
diff --git a/src/views/admin/js/store/modules/item/actions.js b/src/views/admin/js/store/modules/item/actions.js
index 83bf09217..d88ab1ad8 100644
--- a/src/views/admin/js/store/modules/item/actions.js
+++ b/src/views/admin/js/store/modules/item/actions.js
@@ -40,6 +40,27 @@ export const fetchItemMetadata = ({ commit }, item_id) => {
     });
 };
 
+
+// Actions related to Item's metadata
+export const fetchCompoundFirstParentMetaId = ({ commit }, { item_id, metadatum_id }) => {
+   
+    return new Promise((resolve, reject) => {
+        axios.tainacan.patch(`/item/${item_id}/metadata/${metadatum_id}`, { value: [] })
+            .then( res => {
+                const parentMetaId = res.data.parent_meta_id;
+                resolve(parentMetaId);
+            })
+            .catch( error => {
+                reject({
+                    error: error.response.data.errors,
+                    error_message: error.response.data.error_message,
+                    item_metadata: error.response.data.item_metadata
+                });
+            })
+    });
+};
+
+
 export const deleteItemMetadataGroup = ({ commit }, { item_id, metadatum_id, parent_meta_id }) => {
         
     return new Promise((resolve) => {