From 79781c8c3ebb3bd4dfa084db415011a4fa963760 Mon Sep 17 00:00:00 2001 From: Mateus Machado Luna Date: Tue, 7 Aug 2018 09:35:31 -0300 Subject: [PATCH] Deregisters event listener from ItemsPage to avoid access to undefined refs. --- src/admin/admin.vue | 1 + .../tainacan-collection-subheader.vue | 52 +++++++++++++------ .../components/navigation/tainacan-header.vue | 11 +++- src/admin/pages/lists/items-page.vue | 19 ++++--- src/admin/scss/tainacan-admin.scss | 2 +- 5 files changed, 58 insertions(+), 27 deletions(-) diff --git a/src/admin/admin.vue b/src/admin/admin.vue index 985645876..fd90f3290 100644 --- a/src/admin/admin.vue +++ b/src/admin/admin.vue @@ -6,6 +6,7 @@ :active-route="activeRoute" :is-menu-compressed="isMenuCompressed"/> +
-
+
+ +
+
{ this.isLoadingMetadata = false; }); + }, + adjustSearchControlHeight() { + this.$nextTick(() => { + this.searchControlHeight = this.$refs['search-control'] ? this.$refs['search-control'].clientHeight : 0; + this.isFiltersMenuCompressed = jQuery(window).width() <= 768; + }); } }, created() { @@ -1087,14 +1093,11 @@ } // Watches window resize to adjust filter's top position and compression on mobile - this.$nextTick(() => { - this.searchControlHeight = this.$refs['search-control'].clientHeight; - this.isFiltersMenuCompressed = jQuery(window).width() <= 768; - window.addEventListener('resize', () => { - this.isFiltersMenuCompressed = jQuery(window).width() <= 768; - this.searchControlHeight = this.$refs['search-control'].clientHeight; - }); - }) + window.addEventListener('resize', this.adjustSearchControlHeight()); + }, + beforeDestroy() { + this.$off(); + window.removeEventListener('resize', this.adjustSearchControlHeight()); } } diff --git a/src/admin/scss/tainacan-admin.scss b/src/admin/scss/tainacan-admin.scss index 92e98e9a5..6ab79d441 100644 --- a/src/admin/scss/tainacan-admin.scss +++ b/src/admin/scss/tainacan-admin.scss @@ -71,7 +71,7 @@ a:hover { height: $page-height !important; @media screen and (max-width: 769px) { - margin-top: 0; + margin-top: 42px; } .is-primary:not(.upload-draggable), .is-primary:hover, .is-primary:focus {