From be7eb7b5444effe64eb42e999095bd0ced642cf9 Mon Sep 17 00:00:00 2001
From: mateuswetah <mateus.m.luna@gmail.com>
Date: Sat, 2 Jun 2018 02:04:35 -0300
Subject: [PATCH] Removes collapse event binding from computed property
 function in TainacanFormItem (was causing a loop). Closes #57.

---
 src/classes/field-types/tainacan-form-item.vue | 14 ++++++--------
 src/js/event-bus-web-components.js             |  3 ++-
 2 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/src/classes/field-types/tainacan-form-item.vue b/src/classes/field-types/tainacan-form-item.vue
index 768b4d44c..c09ccb15a 100644
--- a/src/classes/field-types/tainacan-form-item.vue
+++ b/src/classes/field-types/tainacan-form-item.vue
@@ -5,10 +5,10 @@
             :type="fieldTypeMessage">
         <span   
                 class="collapse-handle"
-                @click="$emit('changeCollapse', !isCollapsed)">
+                @click="$emit('changeCollapse', fieldTypeMessage != 'is-danger' ? !isCollapsed : true)">
             <b-icon 
                     type="is-secondary"
-                    :icon="isCollapsed ? 'menu-down' : 'menu-right'" />
+                    :icon="isCollapsed || fieldTypeMessage == 'is-danger' ? 'menu-down' : 'menu-right'" />
             <label class="label">{{ field.field.name }}</label>
             <span
                     v-if="field.field.required == 'yes'" 
@@ -20,7 +20,7 @@
                     :message="field.field.description"/>
         </span>
         <div   
-                v-show="isCollapsed" 
+                v-show="isCollapsed || fieldTypeMessage == 'is-danger'" 
                 v-if="isTextInputComponent( field.field.field_type_object.component )">
             <component 
                     :id="field.field.field_type_object.component + '-' + field.field.slug" 
@@ -87,19 +87,19 @@
                 
                 let msg = '';
                 let errors = eventBus.getErrors(this.field.field.id);
-                
+
                 if ( errors) {
                     this.setFieldTypeMessage('is-danger');
                     for (let error of errors) { 
                         for (let index of Object.keys(error)) {
-                            //this.$console.log(index);
+                            // this.$console.log(index);
                             msg += error[index] + '\n';
                         }
                     }
                 } else {
                     this.setFieldTypeMessage('');
                 }
-                
+
                 return msg;
             }
         },
@@ -133,8 +133,6 @@
             },
             setFieldTypeMessage( message ){
                 this.fieldTypeMessage = message;
-                if (message != '')
-                    this.$emit('changeCollapse', true);
             }
         }
     }
diff --git a/src/js/event-bus-web-components.js b/src/js/event-bus-web-components.js
index 965562de6..4dea181e1 100644
--- a/src/js/event-bus-web-components.js
+++ b/src/js/event-bus-web-components.js
@@ -36,6 +36,7 @@ export const eventBus = new Vue({
         },
         updateValue(data){
             if ( data.item_id ){
+                
                 let values = ( Array.isArray( data.values[0] ) ) ? data.values[0] : data.values ;
                 const promisse = this.$store.dispatch('item/updateMetadata',
                     { item_id: data.item_id, field_id: data.field_id, values: values });
@@ -62,7 +63,7 @@ export const eventBus = new Vue({
                 });
             }
         },
-        getErrors(field_id){
+        getErrors(field_id) {
             let error = this.errors.find( errorItem => errorItem.field_id == field_id );
             return ( error ) ? error.errors : false
         },