add read cap by default for new roles #376

src/classes/api/endpoints/class-tainacan-rest-roles-controller.php

@@ -146,6 +146,10 @@ class REST_Roles_Controller extends REST_Controller {
 		}
 
 		if ($new_role instanceof \WP_Role) {
+
+			// every role should at least be able to read
+			$new_role->add_cap( 'read' );
+
 			return new \WP_REST_Response($this->_prepare_item_for_response($role_slug, $name, $new_role->capabilities, $request), 201);
 		}
 

tests/test-api-roles.php

@@ -483,6 +483,22 @@ class TAINACAN_REST_Roles_Controller extends TAINACAN_UnitApiTestCase {
 
 	}
 
+	function test_new_role_can_read() {
+
+		$request = new \WP_REST_Request('POST', $this->namespace . '/roles');
+
+		$request->set_query_params(['name' => 'New role']);
+
+		$create = $this->server->dispatch($request);
+
+		$this->assertEquals( 201, $create->get_status() );
+
+		$role = get_role('tainacan-new-role');
+
+		$this->assertTrue( $role->has_cap( 'read' ) );
+
+	}
+
 }
 
 ?>