tmdinosaurcenter
/
tainacan
mirror of https://github.com/tainacan/tainacan
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Test and fix capabilities attribution for tainacan roles #205

This commit is contained in:
leogermani 2019-03-13 16:01:09 -03:00 committed by Mateus Machado Luna
parent f24afb456f
commit c4da2e01c6
3 changed files with 69 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/classes/class-tainacan-capabilities.php
View File

@ -465,6 +465,16 @@ class Capabilities {
$role->add_cap($collection_items_caps->$cap); $role->add_cap($collection_items_caps->$cap);
$this->check_dependencies($role, 'tainacan-items', $cap); $this->check_dependencies($role, 'tainacan-items', $cap);
} }
// Tainacan relative role
$role = get_role('tainacan-' . $role_name);
if (\is_object($role)) {
foreach ($caps as $cap) {
$role->add_cap($collection_items_caps->$cap);
$this->check_dependencies($role, 'tainacan-items', $cap);
}
}
} }
// Refresh roles capabilities for current user to have instant effect // Refresh roles capabilities for current user to have instant effect

2
tests/test-api-items.php
View File

@ -413,7 +413,7 @@ class TAINACAN_REST_Items_Controller extends TAINACAN_UnitApiTestCase {
//create user as tainacan author //create user as tainacan author
$new_user = $this->factory()->user->create(array('role' => 'author')); $new_user = $this->factory()->user->create(array('role' => 'tainacan-author'));
//$new_user = $this->factory()->user->create(array( 'role' => 'administrator' )); //$new_user = $this->factory()->user->create(array( 'role' => 'administrator' ));
wp_set_current_user($new_user); wp_set_current_user($new_user);
$user_id = get_current_user_id(); $user_id = get_current_user_id();

58
tests/test-permissions.php
View File

@ -147,4 +147,62 @@ class Permissions extends TAINACAN_UnitTestCase {
} }
/**
* @group permission_others_collections
*/
function test_edit_others_collections_tainacan_role() {
$collection = $this->tainacan_entity_factory->create_entity(
'collection',
array(
'name' => 'teste1',
'description' => 'adasdasdsa',
),
true
);
$item = $this->tainacan_entity_factory->create_entity(
'item',
array(
'title' => 'testeItem',
'collection' => $collection,
),
true
);
$new_author_user = $this->factory()->user->create(array( 'role' => 'tainacan-author' ));
wp_set_current_user($new_author_user);
$collection2 = $this->tainacan_entity_factory->create_entity(
'collection',
array(
'name' => 'teste2',
'description' => 'adasdasdsa',
),
true
);
$item2 = $this->tainacan_entity_factory->create_entity(
'item',
array(
'title' => 'testeItem',
'collection' => $collection2,
),
true
);
// Once we had a bug that items of all collections shared the same capability type. they should not.
// This test avoid it to happen
$this->assertNotEquals($item2->get_capabilities()->edit_posts, $item->get_capabilities()->edit_posts);
$this->assertTrue(current_user_can( $item2->get_capabilities()->edit_post, $item2->get_id() ), 'author should be able to edit items in his collection');
$this->assertFalse(current_user_can( $item->get_capabilities()->edit_post, $item->get_id() ), 'author should not be able to edit items in admins collection');
$this->assertTrue($item2->can_edit(), 'author should be able to edit items in his collection');
$this->assertFalse($item->can_edit(), 'author should not be able to edit items in admins collection');
$this->assertNotEquals($item->get_capabilities()->edit_posts, $item2->get_capabilities()->edit_posts);
}
} }