From 271b278d1c46b83bbde94705b05939a57066d347 Mon Sep 17 00:00:00 2001 From: weryques Date: Thu, 13 Dec 2018 17:15:30 -0200 Subject: [PATCH 1/5] Remove console messages and unecessary help messages, and adjusts to new mapping list structure (#160) --- .../edition/exporter-edition-form.vue | 16 ++++--- src/admin/js/router.js | 4 -- .../pages/lists/available-exporters-page.vue | 1 - .../pages/lists/available-importers-page.vue | 1 - src/admin/pages/singles/export-page.vue | 42 ------------------- src/admin/tainacan-admin-i18n.php | 2 - .../class-tainacan-gutenberg-block.php | 20 +++++---- src/js/store/modules/exporter/actions.js | 1 - 8 files changed, 22 insertions(+), 65 deletions(-) delete mode 100644 src/admin/pages/singles/export-page.vue diff --git a/src/admin/components/edition/exporter-edition-form.vue b/src/admin/components/edition/exporter-edition-form.vue index 1ab3e21ce..65eaedffd 100644 --- a/src/admin/components/edition/exporter-edition-form.vue +++ b/src/admin/components/edition/exporter-edition-form.vue @@ -51,7 +51,7 @@ class="is-block" v-if="Object.keys(exporterSession).length && Object.keys(exporterSession.mapping_accept).length && - exporterSession.mapping_accept.any" + exporterSession.mapping_list.length" :label="$i18n.get('mapping')"> @@ -102,6 +102,9 @@ +
+            {{ exporterSession }}
+        
@@ -174,11 +177,12 @@ formIsValid(){ return ( this.selectedCollection && + ((!this.exporterSession.accept_no_mapping && this.selectedMapping) || + this.exporterSession.accept_no_mapping) && !this.formErrorMessage ); }, verifyError(response){ - console.log(response); if(response.constructor.name === 'Object' && (response.data && response.data.status && response.data.status.toString().split('')[0] != 2) || response.error_message) { diff --git a/src/admin/js/router.js b/src/admin/js/router.js index bf74cbcc4..7934dae48 100644 --- a/src/admin/js/router.js +++ b/src/admin/js/router.js @@ -14,7 +14,6 @@ import Page from '../pages/lists/taxonomies-page.vue' import ActivitiesPage from '../pages/lists/activities-page.vue' import AvailableExportersPage from '../pages/lists/available-exporters-page.vue' import AvailableImportersPage from '../pages/lists/available-importers-page.vue' -import ExportPage from '../pages/singles/export-page.vue' // Edition Form Components import CollectionEditionForm from '../components/edition/collection-edition-form.vue' @@ -82,9 +81,6 @@ const routes = [ { path: '/importers/:importerSlug/:sessionId', name: 'ImporterCreationForm', component: ImporterEditionForm, meta: { title: i18nGet('title_importer_page'), icon: 'import' } }, { path: '/importers/:importerType/:sessionId/mapping/:collectionId', name: 'ImporterMappingForm', component: ImporterMappingForm, meta: {title: i18nGet('title_importer_mapping_page'), icon: 'import'} }, - { path: '/exporters/collection/:collectionId', name: 'ExportCollection', component: ExportPage, meta: {title: i18nGet('title_export_collection_page'), icon: 'export'} }, - { path: '/exporters/item/:itemId', name: 'ExportItem', component: ExportPage, meta: {title: i18nGet('title_export_item_page'), icon: 'export'} }, - { path: '/exporters', name: 'ExportersPage', component: AvailableExportersPage, meta: {title: i18nGet('title_exporters_page'), icon: 'export'} }, { path: '/exporters/:exporterSlug', name: 'ExporterEditionForm', component: ExporterEditionForm, meta: {title: i18nGet('title_exporter_page'), icon: 'export'}}, diff --git a/src/admin/pages/lists/available-exporters-page.vue b/src/admin/pages/lists/available-exporters-page.vue index bd3dc4279..f26a631c0 100644 --- a/src/admin/pages/lists/available-exporters-page.vue +++ b/src/admin/pages/lists/available-exporters-page.vue @@ -4,7 +4,6 @@ :bread-crumb-items="[{ path: '', label: $i18n.get('exporters') }]" />

{{ $i18n.get('label_available_exporters') }}

-

{{ $i18n.get('info_available_exporters_helper') }}

{{ $i18n.get('instruction_select_an_exporter_type') }}

{{ $i18n.get('label_available_importers') }}

-

{{ $i18n.get('info_available_importers_helper') }}

{{ $i18n.get('instruction_select_an_importer_type') }}

-
-
- - -
-
- - - - - - - diff --git a/src/admin/tainacan-admin-i18n.php b/src/admin/tainacan-admin-i18n.php index b17dfcf2d..894ca1b1a 100644 --- a/src/admin/tainacan-admin-i18n.php +++ b/src/admin/tainacan-admin-i18n.php @@ -468,7 +468,6 @@ return apply_filters( 'tainacan-admin-i18n', [ 'info_create_filters' => __( 'Click or Drag and Drop Metadata here for creating a new Filter.', 'tainacan' ), 'info_create_metadata' => __( 'Click or Drag and Drop Metadata Types here for creating a new Metadata.', 'tainacan' ), 'info_choose_your_metadata' => __( 'Choose your metadata.', 'tainacan' ), - 'info_available_importers_helper' => __( 'The available importer type will affect the file or link that will provide your data besides deciding wich options are available to the importer.', 'tainacan' ), 'info_target_collection_helper' => __( 'The collection where imported item will be added.', 'tainacan' ), 'info_source_file_upload' => __( 'The file containing the data to be imported.', 'tainacan' ), 'info_metadata_mapping_helper' => __( 'Map each file metadata with the corresponding one in selected collection.', 'tainacan' ), @@ -513,7 +512,6 @@ return apply_filters( 'tainacan-admin-i18n', [ 'info_leaving_bulk_edition' => __( 'You are leaving the bulk edition now.', 'tainacan' ), 'info_current_view_mode_metadata_not_allowed' => __( 'Current view mode does not allow displayed metadata selection.', 'tainacan' ), 'info_cant_select_metadata_without_items' => __( 'Can not select displayed metadata without items on list.', 'tainacan' ), - 'info_available_exporters_helper' => __( '?', 'tainacan' ), 'info_empty' => __( 'empty', 'tainacan' ), 'info_url_copied' => __( 'URL link copied', 'tainacan' ), 'info_other_item_listing_options' => __('Other items listing options: ', 'tainacan'), diff --git a/src/gutenberg-blocks/class-tainacan-gutenberg-block.php b/src/gutenberg-blocks/class-tainacan-gutenberg-block.php index 795e42b1a..7f62e262d 100644 --- a/src/gutenberg-blocks/class-tainacan-gutenberg-block.php +++ b/src/gutenberg-blocks/class-tainacan-gutenberg-block.php @@ -73,10 +73,12 @@ class GutenbergBlock { array('wp-edit-blocks') ); - register_block_type('tainacan/items-grid', array( - 'editor_script' => 'items-grid', - 'style' => 'items-grid' - )); + if(function_exists('register_block_type')) { + register_block_type( 'tainacan/items-grid', array( + 'editor_script' => 'items-grid', + 'style' => 'items-grid' + ) ); + } } public function register_tainacan_collections_carousel(){ @@ -94,10 +96,12 @@ class GutenbergBlock { array('wp-edit-blocks') ); - register_block_type('tainacan/collections-carousel', array( - 'editor_script' => 'collections-carousel', - 'style' => 'collections-carousel' - )); + if(function_exists('register_block_type')) { + register_block_type( 'tainacan/collections-carousel', array( + 'editor_script' => 'collections-carousel', + 'style' => 'collections-carousel' + ) ); + } } public function get_plugin_js_settings(){ diff --git a/src/js/store/modules/exporter/actions.js b/src/js/store/modules/exporter/actions.js index 7321c639f..b8ae73fd5 100644 --- a/src/js/store/modules/exporter/actions.js +++ b/src/js/store/modules/exporter/actions.js @@ -28,7 +28,6 @@ export const updateExporterSession = ({commit}, exporterSessionUpdated) => { return tainacan.patch(`/exporters/session/${exporterSessionUpdated.id}`, exporterSessionUpdated.body) .then(response => { - console.info(response.data); commit('setExporterSession'); return response; From e61e1e1818f81cf68864ecfe62526c2e9b16351d Mon Sep 17 00:00:00 2001 From: Mateus Machado Luna Date: Fri, 14 Dec 2018 09:11:26 -0200 Subject: [PATCH 2/5] Adds proper styling to attachments list on activity modal. --- .../edition/collection-edition-form.vue | 1 + .../components/edition/item-edition-form.vue | 4 +- .../other/activity/activity-details-modal.vue | 84 ++++++++----------- src/admin/components/other/file-item.vue | 53 +++++++----- src/admin/pages/singles/item-page.vue | 2 + src/admin/scss/_modals.scss | 2 +- 6 files changed, 75 insertions(+), 71 deletions(-) diff --git a/src/admin/components/edition/collection-edition-form.vue b/src/admin/components/edition/collection-edition-form.vue index 5fc780135..c98e703b6 100644 --- a/src/admin/components/edition/collection-edition-form.vue +++ b/src/admin/components/edition/collection-edition-form.vue @@ -46,6 +46,7 @@ diff --git a/src/admin/components/other/activity/activity-details-modal.vue b/src/admin/components/other/activity/activity-details-modal.vue index 968478518..18e7a0687 100644 --- a/src/admin/components/other/activity/activity-details-modal.vue +++ b/src/admin/components/other/activity/activity-details-modal.vue @@ -47,30 +47,17 @@
-
@@ -170,29 +157,16 @@ class="tainacan-attachments-in-modal" v-if="diff.new.length">
@@ -321,6 +295,7 @@ -