Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove the usage of `<ReportSummary isRequesting>` as it has no effect (#50751) 

The support for such property was removed in woocommerce/woocommerce-admin#4858 ~4 years ago.

Co-authored-by: github-actions <github-actions@github.com>
This commit is contained in:
Tomek Wytrębowicz 2024-08-25 19:56:59 +02:00 committed by GitHub
parent a66d2f8dff
commit 53be5776f4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
7 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/woocommerce-admin/client/analytics/components/report-summary/test/index.js
View File

@ -134,7 +134,7 @@ describe( 'ReportSummary', () => {
).toBeInTheDocument(); ).toBeInTheDocument();
} ); } );
test( 'should display SummaryListPlaceholder when isRequesting is true', () => { test( 'should display SummaryListPlaceholder when summaryData.isRequesting is true', () => {
const { container } = renderChart( 'number', null, null, false, true ); const { container } = renderChart( 'number', null, null, false, true );
expect( expect(

1
plugins/woocommerce-admin/client/analytics/report/categories/index.js
View File

@ -69,7 +69,6 @@ class CategoriesReport extends Component {
<ReportSummary <ReportSummary
charts={ charts } charts={ charts }
endpoint="products" endpoint="products"
isRequesting={ isRequesting }
limitProperties={ limitProperties={
isSingleCategoryView isSingleCategoryView
? [ 'products', 'categories' ] ? [ 'products', 'categories' ]

1
plugins/woocommerce-admin/client/analytics/report/coupons/index.js
View File

@ -57,7 +57,6 @@ class CouponsReport extends Component {
<ReportSummary <ReportSummary
charts={ charts } charts={ charts }
endpoint="coupons" endpoint="coupons"
isRequesting={ isRequesting }
query={ chartQuery } query={ chartQuery }
selectedChart={ getSelectedChart( query.chart, charts ) } selectedChart={ getSelectedChart( query.chart, charts ) }
filters={ filters } filters={ filters }

1
plugins/woocommerce-admin/client/analytics/report/products/index.js
View File

@ -82,7 +82,6 @@ class ProductsReport extends Component {
mode={ mode } mode={ mode }
charts={ charts } charts={ charts }
endpoint="products" endpoint="products"
isRequesting={ isRequesting }
query={ chartQuery } query={ chartQuery }
selectedChart={ getSelectedChart( query.chart, charts ) } selectedChart={ getSelectedChart( query.chart, charts ) }
filters={ filters } filters={ filters }

1
plugins/woocommerce-admin/client/analytics/report/taxes/index.js
View File

@ -52,7 +52,6 @@ class TaxesReport extends Component {
<ReportSummary <ReportSummary
charts={ charts } charts={ charts }
endpoint="taxes" endpoint="taxes"
isRequesting={ isRequesting }
query={ chartQuery } query={ chartQuery }
selectedChart={ getSelectedChart( query.chart, charts ) } selectedChart={ getSelectedChart( query.chart, charts ) }
filters={ filters } filters={ filters }

1
plugins/woocommerce-admin/client/analytics/report/variations/index.js
View File

@ -59,7 +59,6 @@ const VariationsReport = ( props ) => {
mode={ mode } mode={ mode }
charts={ charts } charts={ charts }
endpoint="variations" endpoint="variations"
isRequesting={ isRequesting }
query={ chartQuery } query={ chartQuery }
selectedChart={ getSelectedChart( query.chart, charts ) } selectedChart={ getSelectedChart( query.chart, charts ) }
filters={ filters } filters={ filters }

4
plugins/woocommerce/changelog/50751-fix-isRequesting-report-summary Normal file
View File

@ -0,0 +1,4 @@
Significance: patch
Type: tweak
Remove the usage of `ReportSummary`s `isRequesting` property as it has no effect.