Steve-Dee-Designs
/
woocommerce
mirror of https://github.com/woocommerce/woocommerce.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[Experimental] Product Gallery block: Rename media setting to "Open pop-up when clicked" (#43302) 

* Rename media setting to "Open pop-up when clicked"

* Add changefile(s) from automation for the following project(s): woocommerce-blocks

---------

Co-authored-by: github-actions <github-actions@github.com>
This commit is contained in:
Alexandre Lara 2024-01-08 16:58:27 -03:00 committed by GitHub
parent aa0f1b14b3
commit 65d9c6764c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/woocommerce-blocks/assets/js/blocks/product-gallery/block-settings/index.tsx
View File

@ -75,7 +75,7 @@ export const ProductGalleryBlockSettings = ( {
}
/>
<ToggleControl
label={ __( 'Full-screen when clicked', 'woocommerce' ) }
label={ __( 'Open pop-up when clicked', 'woocommerce' ) }
help={ __(
'Clicking on the large image will open a full-screen gallery experience.',
'woocommerce'

2
plugins/woocommerce-blocks/tests/e2e/tests/product-gallery/product-gallery.block_theme.side_effects.spec.ts
View File

@ -493,7 +493,7 @@ test.describe( `${ blockData.name }`, () => {
} );
} );
test.describe( 'full-screen when clicked option', () => {
test.describe( 'open pop-up when clicked option', () => {
test( 'should be enabled by default', async ( {
pageObject,
editor,

2
plugins/woocommerce-blocks/tests/e2e/tests/product-gallery/product-gallery.page.ts
View File

@ -10,7 +10,7 @@ const selectors = {
zoomWhileHoveringSetting:
"xpath=//label[contains(text(), 'Zoom while hovering')]/preceding-sibling::span/input",
fullScreenOnClickSetting:
"xpath=//label[contains(text(), 'Full-screen when clicked')]/preceding-sibling::span/input",
"xpath=//label[contains(text(), 'Open pop-up when clicked')]/preceding-sibling::span/input",
},
};

4
plugins/woocommerce/changelog/43302-refactor-43295-rename-media-setting-full-screen-when-clicked Normal file
View File

@ -0,0 +1,4 @@
Significance: patch
Type: dev
Comment: Rename the media setting from "Full-screen when clicked" to "Open pop-up when clicked"