Update to PR template (https://github.com/woocommerce/woocommerce-blocks/pull/10549)
This commit is contained in:
Tom Cafferkey
GitHub
parent
ee9b93a026
commit
efec0bbd02
|
|
@ -1,47 +1,19 @@
|
|||
<!-- Start by describing the changes made in this Pull Request, and the reason for such changes. -->
|
||||
<!-- Please do not remove any information from this pull request. Instead, add N/A or leave blank if not applicable -->
|
||||
|
||||
<!-- Reference any related issues or PRs here -->
|
||||
## What
|
||||
|
||||
Fixes #
|
||||
|
||||
<!-- Don't forget to update the title with something descriptive. -->
|
||||
<!-- If you can, add the appropriate labels -->
|
||||
## Why
|
||||
|
||||
#### Accessibility
|
||||
<!-- Describe the reason for your changes. This will help the reviewer and future readers get additional context -->
|
||||
|
||||
<!-- If you've changed or added any interactions, check off the appropriate items below. You can delete any that don't apply. Use this space to elaborate on anything if needed. -->
|
||||
|
||||
- [ ] I've tested using only a keyboard (no mouse)
|
||||
- [ ] I've tested using a screen reader
|
||||
- [ ] All animations respect [`prefers-reduced-motion`](https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion)
|
||||
- [ ] All text has [at least a 4.5 color contrast with its background](https://webaim.org/resources/contrastchecker/)
|
||||
|
||||
#### Other Checks
|
||||
|
||||
- [ ] This PR has either a `[type]` label or a `[skip-changelog]` label.
|
||||
- [ ] This PR adds/removes a feature flag & I've updated [this doc](https://github.com/woocommerce/woocommerce-blocks/blob/trunk/docs/internal-developers/blocks/feature-flags-and-experimental-interfaces.md).
|
||||
- [ ] This PR adds/removes an experimental interfaces and I've updated [this doc](https://github.com/woocommerce/woocommerce-blocks/blob/trunk/docs/internal-developers/blocks/feature-flags-and-experimental-interfaces.md).
|
||||
- [ ] I tagged two reviewers because this PR makes queries to the database or I think it might have some security impact.
|
||||
|
||||
### Screenshots
|
||||
|
||||
<!-- If your change has a visual component, add a screenshot here. A "before" screenshot would also be helpful. -->
|
||||
|
||||
| Before | After |
|
||||
| ------ | ----- |
|
||||
| | |
|
||||
|
||||
### Testing
|
||||
|
||||
#### Automated Tests
|
||||
* [ ] Changes in this PR are covered by Automated Tests.
|
||||
* [ ] Unit tests
|
||||
* [ ] E2E tests
|
||||
|
||||
#### User Facing Testing
|
||||
## Testing Instructions
|
||||
|
||||
<!-- Write these steps from the perspective of a "user" (merchant) familiar with WooCommerce. No need to spell out the steps for common setup scenarios (eg. "Create a product"), but do be specific about the thing being tested. Include screenshots demonstrating expectations where that will be helpful. -->
|
||||
|
||||
_Please consider any edge cases this change may have, and also other areas of the product this may impact._
|
||||
|
||||
1.
|
||||
2.
|
||||
3.
|
||||
|
|
@ -49,18 +21,38 @@ Fixes #
|
|||
* [ ] Do not include in the Testing Notes <!-- Check this box if this PR can't be tested (ie: it makes changes to tests, coding standards, docblocks, etc.). -->
|
||||
* [ ] Should be tested by the development team exclusively <!-- Check this box if this PR should be tested by the development team exclusively (ie: it doesn't include user-facing changes or it can't be tested without manually modifying the code). -->
|
||||
|
||||
### WooCommerce Visibility
|
||||
## Screenshots or screencast
|
||||
|
||||
<!-- Check this [this doc](../docs/blocks/feature-flags-and-experimental-interfaces.md) to see if the change is visible in WC core or not (part of the feature plugin or experimental)-->
|
||||
<!-- Any screenshots of UI changes will be helpful to include here. Leave blank if not applicable. -->
|
||||
|
||||
| Before | After |
|
||||
| ------ | ----- |
|
||||
| | |
|
||||
|
||||
## WooCommerce Visibility
|
||||
|
||||
<!-- Check this documentation link (../docs/blocks/feature-flags-and-experimental-interfaces.md) to see if the change is visible in WooCommerce core, part of the feature plugin, or experimental. -->
|
||||
Required:
|
||||
|
||||
* [ ] WooCommerce Core
|
||||
* [ ] Feature plugin
|
||||
* [ ] Experimental
|
||||
* [ ] N/A
|
||||
|
||||
### Performance Impact
|
||||
## Checklist
|
||||
|
||||
<!-- Please document any known performance impact (positive or negative) here. If negative, provide some rationale for why this is an okay tradeoff or how this will be addressed. -->
|
||||
Required:
|
||||
* [ ] This PR has either a `[type]` label or a `[skip-changelog]` label.
|
||||
* [ ] This PR is assigned to a milestone.
|
||||
|
||||
### Changelog
|
||||
Conditional:
|
||||
* [ ] This PR has a changelog description (if `[skip-changelog]` label is not present).
|
||||
* [ ] This PR adds/removes a feature flag & I've updated [this doc](https://github.com/woocommerce/woocommerce-blocks/blob/trunk/docs/internal-developers/blocks/feature-flags-and-experimental-interfaces.md).
|
||||
* [ ] This PR adds/removes an experimental interfaces, and I've updated [this doc](https://github.com/woocommerce/woocommerce-blocks/blob/trunk/docs/internal-developers/blocks/feature-flags-and-experimental-interfaces.md).
|
||||
* [ ] This PR has been accessibility tested.
|
||||
* [ ] This PR has had any necessary documentation added/updated.
|
||||
|
||||
## Changelog
|
||||
<!-- Provide a brief, descriptive summary of the changes in this PR. Include potential impacts on different parts of the product. Example: "Updated the checkout process to streamline the experience for users and reduce the number of steps." -->
|
||||
|
||||
> Add suggested changelog entry here.
|
||||
|
|
|
|||
Loading…
Reference in New Issue