03889f77cc
Update use of deprecated wc_get_log_file_path
2016-12-29 11:58:43 +01:00
af7b8646c5
Remove unneeded setUp and tearDown
...
WC_Logger tests no longer depend on writing/reading from log files.
2016-12-29 11:58:43 +01:00
088fc5cd68
Delay file log write when written too early
...
The function to look up log file paths depends on `wp_hash`, which is pluggable.
Log files cannot be found before `plugins_loaded` action. In case a log is
written to a file before `wp_hash` is available, cache and write on
`plugins_loaded` action.
2016-12-29 11:58:43 +01:00
5700043e6d
Deprecate wc_get_log_file_path
...
wc_get_log_file_path moves into `WC_Log_Handler_File` class as a static
method.
Update deprecations and version info.
2016-12-29 11:58:43 +01:00
065277a596
Fix WC_Logger::add test to match new 'notice' level.
2016-12-29 11:58:43 +01:00
feefabbdf0
Document _legacy context in WC_Log_Handler_File
2016-12-29 11:58:43 +01:00
665e8ccfc6
Improve doc comments and access.
2016-12-29 11:58:43 +01:00
f908a0181c
Improve deprecation messages for WC_Logger
...
clear and remove *do* have alternatives. They have essentially
been moved to the file handler.
2016-12-29 11:58:43 +01:00
6068f681d3
Use 'notice' as level for deprecated WC_Logger::add messages.
...
Notice is the default (and recommended) threshold for production sites. Using
info, which is below notice, would result in ::add messages to be filtered by
default. This would be a confusing experience for users calling the deprecated
function and expecting a log.
2016-12-29 11:58:43 +01:00
de076a313e
Fix settings log texts
...
Add 'woocommerce' to __ translated texts.
Improve texts.
2016-12-29 11:58:43 +01:00
d4e8bb82e6
Remove new handler arguments from `wc_register_default_log_handler`
2016-12-29 11:58:43 +01:00
970a33e182
Cleanup log list table view
...
Format log timestamp.
Add is_valid_level check to $_REQUEST level filter.
General cleanup: formatting, layout, commentary.
2016-12-29 11:58:43 +01:00
50eb303a73
Fix WC_Log_Levels::is_valid_level tests
...
The wrong method was being called in tests.
2016-12-29 11:58:43 +01:00
23a45125e7
Add unit tests for wc_print_r()
...
Clean up some log logic ( `assertEquals( true ... )` becomse `assertTrue( ... )` ).
2016-12-29 11:58:43 +01:00
aee5917440
Change wc_safe_dump to wc_print_r
...
Match print_r arguments, this makes usage obvious.
2016-12-29 11:58:43 +01:00
3f4b473a48
Improve PHP 5.2 test compatibility (older PHPUnit version)
2016-12-29 11:58:43 +01:00
b94d029546
Improve test compatibility (PHP 5.2)
2016-12-29 11:58:43 +01:00
2ae1bc1ab2
Protect methods
2016-12-29 11:58:43 +01:00
fe837c5113
Aggregate email handler messages (max: 1 email/request/handler)
...
Update emails accordingly.
Update email handler tests.
2016-12-29 11:58:43 +01:00
acc98a1d6a
Mark WC_Log_Handler::format_entry abstract
2016-12-29 11:58:43 +01:00
5f24eca7e2
Add delete to db log viewer table
...
Clean up some nonce logic.
Use a single <form> containing log table.
2016-12-29 11:58:43 +01:00
9ba616b2c1
Return single instance from wc_get_logger
...
Remove class include from wc_get_logger (should be autoloaded).
Add tests for wc_get_logger.
2016-12-29 11:58:43 +01:00
4318b3aa53
Improve @return signature on WC_Log_Handler::handle
...
Make meaning of returned bool explicit.
Update WC_Log_Handler_Email::handle accordingly.
via https://github.com/woocommerce/woocommerce/pull/12575#pullrequestreview-12381573
2016-12-29 11:58:43 +01:00
81eaa5ae17
Make lot threshold strings translatable
2016-12-29 11:58:43 +01:00
5af479f61b
Add email log handler tests
2016-12-29 11:58:43 +01:00
080cf8e436
Store log levels as integer representations in database
...
This will allow indexed ordering by severity.
Add WC_Log_Levels::get_severity_level method to translate severity
integers to level strings. The inverse of WC_Log_Levels::get_level_severity.
Add context to tests.
2016-12-29 11:58:43 +01:00
78e6cb31a7
Include WC_Log_Handler with other abstracts
2016-12-29 11:58:43 +01:00
825d9c9f82
Fix spelling
2016-12-29 11:58:43 +01:00
88836b9cca
Drop WP_DEBUG override threshold. Improve logger tests.
...
This may be unexpected behavior for a user, their level is overridden with no
way to change it. It also greatly complicates testing default thresholds.
Dependency on WC_Log_Handler_File has been removed from logger tests.
2016-12-29 11:58:43 +01:00
0bea7e1305
Improve logger tests
2016-12-29 11:58:43 +01:00
0389909d88
Improve logger tests
2016-12-29 11:58:43 +01:00
2626c5b3af
Accept explicit handlers and threshold in WC_Logger
2016-12-29 11:58:43 +01:00
be38e8f2fe
Add log threshold setting to settings page
2016-12-29 11:58:43 +01:00
ffd0d380ee
Remove threshold logic from handlers.
...
Email handler implements threshold logic internally. Other handlers handle all logs received.
Handler constructors have changed.
2016-12-29 11:58:43 +01:00
2945b4755f
Add more information about log levels
2016-12-29 11:58:43 +01:00
85fa9df7fe
Drop "bubbling" support for logs
...
The concept of bubbling or consuming logs has little benefit for our use case.
Drop support for bubbling and simplify logging.
2016-12-29 11:58:43 +01:00
4f77954bc7
Move log levels to independent class
2016-12-29 11:58:43 +01:00
ae72ce24c4
Drop `var_dump` as safe dump alternative
...
var_dump does not support returning string representation.
2016-12-29 11:58:43 +01:00
d88ea4ecea
Spelling and doc fixes
2016-12-29 11:58:43 +01:00
60314e5ba1
Fix spelling errors
2016-12-29 11:58:43 +01:00
eca10f6362
Explicit use of file log handler for logger tests
2016-12-29 11:58:43 +01:00
0f13cca921
Use autoloader for log handlers
2016-12-29 11:58:43 +01:00
e2f76bcd54
Fix logs-db redirects
2016-12-29 11:58:42 +01:00
c633db9d65
Add woocommerce_default_log_handler setting
...
Adds configuration to settings page
Show status-logs page based on settings (unify logs & database logs)
Register default log handler by default
2016-12-29 11:58:42 +01:00
81223995fc
Add basic email logger test
2016-12-29 11:58:42 +01:00
ceea56e323
Add test for multiple file log handlers writing to same file.
2016-12-29 11:58:42 +01:00
b6304cbcc4
Prefer "unit-tests" tag for testing log handler
2016-12-29 11:58:42 +01:00
dd2474fb3c
Rename test file log -> logger
2016-12-29 11:58:42 +01:00
dce4e7c21a
Fix misnamed test class
2016-12-29 11:58:42 +01:00
e5b369b431
Remove bad logger test
...
Test comparing equality of logger results could randomly fail depending on execution time.
The coverage was duplicated by other tests, test was redundant and has been removed.
2016-12-29 11:58:42 +01:00
Jon Surrell
Jonathan Surrell