0a81188e42
Merge pull request #27987 from woocommerce/php8/fix-required-parameters-after-optional-take-2
...
[PHP 8] Convert optional-before-required parameters into required parameters (take 2)
2020-10-17 09:42:20 -03:00
e8bcd464db
Update escape based on suggestion
2020-10-16 06:00:34 -07:00
63ced34e2d
Convert optional-before-required arguments to required (take 2)
...
In PHP 8 required parameters after optional parameters in
function/method signatures trigger a deprecation notice. These type
of parameters are pointless since a value needs to always be
provided for them anyway, so they are actually de-facto required.
This commit converts all these not-so-optional parameters into
truly required parameters by removing their default values.
2020-10-16 13:08:31 +02:00
800cbdbc7e
Add missing escapes
2020-10-15 16:31:56 -07:00
ace411aacd
Fix billing email being parsed as a URL link when beginning of email contains www closes #25099
2020-10-15 14:25:03 -07:00
9155a78043
Merge pull request #27858 from Rowayda-Khayri/fixes
...
Add punctuation mark to function's docblock
2020-10-15 15:09:21 -03:00
e4a109f0d1
Merge pull request #27763 from woocommerce/fix/27445
...
Remove protection as we already diff and update only if needed.
2020-10-15 10:01:34 +02:00
e34681dbb4
Merge pull request #27696 from woocommerce/fix/version-race-conditions
...
Fix some race conditions in WC_Install
2020-10-14 20:18:47 -03:00
d211f6ee5c
Merge pull request #27516 from KoolPal/patch-2
...
Renamed Postcode / ZIP to Pin code & renamed State / County to State for India
2020-10-14 19:51:46 -03:00
0b41aff81b
Merge pull request #27546 from KoolPal/patch-1
...
Updated - Added postcode validation for India
2020-10-14 19:25:32 -03:00
e581ffce27
Fixed missing "break"
2020-10-14 19:22:19 -03:00
136c6e2916
Merge pull request #27779 from zzap/patch-2
...
Update properties for Serbia.
2020-10-14 18:09:56 -03:00
23fe4f71bb
Merge pull request #27842 from sudoshreyansh/fix/27839
...
Fixed </strong> closing tag position. Issue: #27839
2020-10-14 18:06:10 -03:00
537ec5d0e9
Merge pull request #27893 from dominic-ks/update-needs-payment-check
...
issue #24631 - Updated needs payment check to use order
2020-10-14 16:29:25 -03:00
27e4288eab
Merge pull request #27934 from woocommerce/remove_get_product_from_item
...
Remove the remaining uses of $order->get_product_from_item()
2020-10-14 16:18:29 -03:00
c530fc0d55
Merge pull request #27908 from woocommerce/fix/template-attachment-ids
...
restore $attachment_ids for product thumbnails template
2020-10-14 15:38:19 -03:00
6ad79cf050
Fixed PHP notice
...
> PHP Notice: compact(): Undefined variable: gallery_image_ids in includes/wc-template-functions.php on line 1487
2020-10-14 15:37:12 -03:00
47a7c6648a
Update includes/wc-template-functions.php
2020-10-14 15:29:24 -03:00
f65491d1b2
Merge pull request #27898 from woocommerce/add/allow-customise-reset-password-page-title
...
Use "Set Password" page title for lost-password endpoint when setting a password
2020-10-14 23:24:27 +05:30
be4aacee93
Merge pull request #27483 from woocommerce/fix/27475
...
prevent regenerate image filter loop
2020-10-14 14:03:00 -03:00
7d1ff1a655
Merge pull request #27310 from woocommerce/fix/27215
...
Fix deleting a tax class via WP CLI.
2020-10-14 14:00:33 -03:00
9cf2d81f60
Merge branch 'master' into fix/template-attachment-ids
2020-10-14 12:40:57 -03:00
8ec54fabe0
phpcs fixes
2020-10-14 10:27:58 -03:00
cd20044b13
Merge branch 'master' into fix/27215
2020-10-14 10:16:36 -03:00
c01f32a390
Use default value if formatted value is not available
2020-10-14 14:51:19 +05:30
8e12de5d3c
Merge branch 'fix/api/229-unit-test' of https://github.com/shiki/woocommerce into fix/api/229
2020-10-14 13:53:03 +05:30
95f4b5b81e
restore original comment (related changes are gone)
2020-10-14 12:35:32 +13:00
5e3713da75
check password-set user token before redirecting to set password form:
...
- this prevents the password reset process earlier (before the redirect)
- also now shows a notice informing the user that they need to log out
of (other) account
2020-10-14 12:26:51 +13:00
1f5601f0fe
ensure lost-password form only resets password for correct user:
...
- if a user is logged in, check their ID matches the ID in the reset
key / token
2020-10-14 12:12:01 +13:00
5e5d06cfab
show lost-password form when logged-in user:
...
- in the checkout signup use case, the user may be setting their
password in a logged-in browser session; they need to be able to set an
initial account password
2020-10-14 09:50:36 +13:00
b34ad5be5c
improve PHPdocs for get_endpoint_title and related hook:
...
- add @since (original since based on git blame)
- document all params
- add @since for newly-added params
- add docs for woocommerce_endpoint_{$endpoint}_title
2020-10-14 09:50:36 +13:00
6032962e59
use "Set password" title for lost-password endpoint for more actions:
...
- 'rp' and 'resetpass' are used in WordPress core
1079647d30/wp-login.php (L913)
2020-10-14 09:50:36 +13:00
1eb02845aa
support overriding/customising password reset page title via `action`:
...
- get_endpoint_title now takes an extra `action` param
- this also is passed to the relevant hook (as an additional arg)
- woocommerce_endpoint_{$endpoint}_title
- for `lost-password?action=rp`, use `Set password`
- pass action query param through when using get_endpoint_title
2020-10-14 09:50:36 +13:00
e655b44717
Fixed coding standards
2020-10-13 22:32:32 +05:30
2e165e7558
Orders: Make display_key and _value meta available for v3 and v3
...
This resolves the intentionally failing
WC_Tests_API_Orders_V2::test_get_item_with_line_items_meta_data.
2020-10-13 22:32:31 +05:30
a3f46e5526
Schema: Make display_key and *_value available for v3 and v2
...
This is just the schema and the actual functionality isn't implemented yet.
2020-10-13 22:32:30 +05:30
b9ae830da5
Fix formatting in Orders V2 unit test
2020-10-13 22:32:30 +05:30
f45e8b884b
Orders V3: Reuse WC_Order_Item->get_formatted_meta_data
...
Previously, I was using my own function. This time, we're using the function
available in WC_Order_Item but sanitizing the results after.
2020-10-13 22:32:30 +05:30
2e92460df2
Orders V3: Include display_key and display_value in item meta_data
2020-10-13 22:32:30 +05:30
d8ac282c80
Orders V3 Schema: Add display_key and display_value for meta props
2020-10-13 22:32:29 +05:30
1fcedb5279
Removes the remaining uses of $order->get_product_from_item
2020-10-13 11:24:48 +10:00
c15488d840
Merge pull request #27830 from woocommerce/php8/fix-round-function-with-non-numeric-argument
2020-10-09 08:01:44 +02:00
6861fdab5d
Update @version in which a filter was added
2020-10-08 17:03:09 -03:00
0fedb0db7a
Added filter for low stock notification emails ( #27819 )
...
* Adding new filter for low stock notification
* Update class-wc-emails.php
fixing whitespace
2020-10-08 17:02:09 -03:00
4a8898dfbd
restore $attachment_ids for product thumbnails template
2020-10-08 15:08:03 -03:00
e4b78cedbf
Merge pull request #27748 from woocommerce/remove-leftovers-from-improved-filtering-by-attribute-for-variations
...
Remove leftovers from the reverted improved filtering mechanism for variations
2020-10-08 15:45:09 +02:00
0771138604
Merge pull request #27707 from dd32/php8/warnings
...
PHP8 Warning: Change __wakeup() to a public method
2020-10-08 10:01:21 -03:00
ab529835fa
Merge pull request #27840 from woocommerce/php8/fix-required-parameters-after-optional
...
[PHP 8] Convert optional-before-required parameters into required parameters
2020-10-08 14:22:52 +02:00
8a9fa0d27b
Merge pull request #27587 from om4james/fix/26847-rest-api-auth
...
Fix HTTP 401 `woocommerce_rest_cannot_view` `Sorry, you cannot list resources` REST API response
2020-10-08 16:32:03 +05:30
b71f876cba
Reintroduce the dependency injection related code.
...
After the League's Container package has been reintroduced, all the
code that implements the dependency injection mechanism in woocommerce
can be brought back as well.
2020-10-08 09:28:05 +02:00
Rodrigo Primo
roykho
Nestor Soriano
Claudio Sanches
Vedanshu Jain
Ron Rennick
Rua Haszard
Shiki
James Allan
Jon Campbell