Commit Graph

28098 Commits

Author SHA1 Message Date
Rodrigo Primo 1860cd1933 Change WC_Unit_Test_Case to extend WP_HTTP_TestCase instead of WP_UnitTestCase
This commits changes WC_Unit_Test_Case parent class to WP_HTTP_TestCase (which extends WP_UnitTestCase). This way all WC core test classes can benefit from the functionality provided by WP_HTTP_TestCase if needed. This is necessary because otherwise test classes can use the functionality provided by WC_Unit_Test_Case or WP_HTTP_TestCase. This change should not affect test classes that don't explicitly call one of the WP_HTTP_TestCase features.
2018-07-19 14:17:06 -03:00
Peter Fabian b9cdc760ac
Merge pull request #20817 from keefyhub/master
Add class names to `edit_category_fields()` to be inline with other f…
2018-07-19 18:45:00 +02:00
Gerhard Potgieter 990ab6a910
Merge pull request #20850 from rodrigoprimo/oembed-test
Use an artificial HTTP response for wc_do_oembeds() test
2018-07-19 17:30:44 +02:00
Rodrigo Primo 1d13dd4dd4 Use an artificial HTTP response for wc_do_oembeds() test
Doing this to speed up the test as an HTTP request to an external server is slow and also because it should fix this test that has been failing on Travis only for an unknown reason.
2018-07-19 10:35:32 -03:00
Rodrigo Primo fb9aa71b33 Undoing DB changes on tearDown() is not necessary
WP test suite starts a transaction when the test starts and roll it back when the test finishes. So it is not necessary to undo database changes using tearDown().
2018-07-19 10:35:19 -03:00
Peter Fabian 15e44897f6
Merge pull request #20849 from woocommerce/fix/20838
Add a margin to the bestseller widget product title
2018-07-19 14:27:33 +02:00
Gerhard Potgieter 67b46aadf8 Include postcss task in the watch to be the same as grunt css 2018-07-19 14:12:12 +02:00
Peter Fabian 22059880cd
Merge pull request #20842 from rnaby/180718-221942-wc-data
Unnecessary Variables and Spaces Removed
2018-07-19 13:49:25 +02:00
Gerhard Potgieter 3065eec515 Add a margin to the bestseller widget product title to avoid it overlapping the sparkline when the title is long. 2018-07-19 12:26:45 +02:00
Peter Fabian a26530f84a
Merge pull request #20846 from woocommerce/fix/e2e-tests
Enable SCRIPT_DEBUG on e2e tests
2018-07-19 11:18:38 +02:00
Gerhard Potgieter c3993accd4 Set SCRIPT_DEBUG to true for e2e tests since we never commit minified js during dev, only once we do a release do we minify scripts. 2018-07-19 09:06:11 +02:00
Gerhard Potgieter 30766df5c4
Merge pull request #20840 from woocommerce/add/wp-http-testcase
Fix test failing only the Travis builds
2018-07-19 07:42:02 +02:00
Khan M Rashedun-Naby 25ab294d40 Unnecessay Spaces Removed 2018-07-19 10:33:22 +06:00
Claudio Sanches 09d50df86b
Merge pull request #20753 from ldybecklee/master
Fix product csv exporter get stock value
2018-07-18 21:23:44 -03:00
Rodrigo Primo 34ec2e87c0 Add wp-http-testcase directly to the repository
This commit adds the composer package jdgrimes/wp-http-testcase directly to this repository instead of via composer. Doing this because I couldn't find a way to make this package work on Travis build jobs running older versions of PHP and I don't think it is worth investing much time on it.
2018-07-18 18:19:39 -03:00
Rodrigo Primo 0e785d4614 Make WC_Tests_Product_CSV_Importer::test_import() faster
This commit changes the WC_Tests_Product_CSV_Importer class to use artificial HTTP responses instead of performing real HTTP requests to a external server to get the images of the imported products. On my local machine, this change reduced the test execution time from 3257ms to 831ms.

As a consequence of this change, this commit also fixes WC_Tests_Product_CSV_Importer::test_import() in all Travis builds. This test has been failing for a few weeks on Travis but not on our local environments. After some debugging, I found out that the test was failing on Travis because of the following error when `wp_safe_remote_get()` was called to get images for the imported products:

```
Error getting remote image http://demo.woothemes.com/woocommerce/wp-content/uploads/sites/56/2013/06/T_1_front.jpg. Error: cURL error 35: gnutls_handshake() failed: Handshake failed.
```

Apparently, the PHP binary that is used by Travis is unable to handle the TLS handshake (see https://github.com/travis-ci/travis-ci/issues/6339) and the test probably started failing when demo.woothemes.com (which is used to download the images for the imported products) switched from HTTP to HTTPS.
2018-07-18 17:16:26 -03:00
Rodrigo Primo 5c04cca91c Add jdgrimes/wp-http-testcase composer package
This commit adds jdgrimes/wp-http-testcase (https://github.com/JDGrimes/wp-http-testcase) composer package as a dev requirement. This package provides a PHPUnit testcase for testing code that uses the WP_Http class. Using it it is possible to create artificial HTTP responses skipping the request to external servers and making the tests faster.
2018-07-18 17:10:29 -03:00
Gerhard Potgieter ea2b3f9d7a
Merge pull request #20821 from woocommerce/fix/20718
Pass an instance of the background updater to the db update callbacks
2018-07-18 14:51:12 +02:00
ldybecklee a7de4672dc
Update class-wc-product-csv-exporter.php 2018-07-17 12:10:55 +08:00
ldybecklee 0cf070ed5e
fix method 'get_column_value_stock' 2018-07-17 12:09:34 +08:00
Rodrigo Primo b39b419e5b Pass an instance of the background updater to the db update callbacks
This commit changes the way that WC_Background_Updater::task() calls the database update callbacks and adds the WC_Background_Updater instance as the first parameter to the callbacks. This is used in wc_update_350_order_customer_id() (36b6bd79c0/includes/wc-update-functions.php (L1870)) to monitor memory usage while the function is running. This change was intended to ship with PR #17895 (see commit c77b2f20f4) but was accidentaly removed when merging commit 083c994732 from another PR.

Fixes #20718
2018-07-16 14:24:42 -03:00
Rodrigo Primo bfebd30565
Merge pull request #20726 from itowhid06/master
Convert  hardcoded db prefix to dynamic db prefix. Fixes #20718
2018-07-16 14:21:45 -03:00
Keith Light 4144211754 Add class names to `edit_category_fields()` to be inline with other fields
Class names are added in `add_category_fields()` but not `edit_category_fields()`
2018-07-16 15:24:57 +01:00
Claudiu Lodromanean ef00985e44
Merge pull request #20762 from woocommerce/fix/20752
Fixed notice when variation does not exists on frontend
2018-07-12 11:59:05 -07:00
Peter Fabian 3fa3830b6c
Merge pull request #20757 from woocommerce/update/wc_get_user_agent
Make wc_get_user_agent respect RFC2616
2018-07-12 11:46:51 +02:00
Claudio Sanches 2a1940aeba Fixed notice when variation does not exists on frontend
Closes #20752
2018-07-11 22:02:56 -03:00
Claudiu Lodromanean 6dbd5d5323
Merge pull request #20731 from woocommerce/add/20724
Do not load all tables in multisite system status
2018-07-11 13:42:52 -07:00
Gerhard Potgieter a6e7ae15f9 Add unit test for testing wc_get_user_agent 2018-07-11 14:11:31 +02:00
Gerhard Potgieter f0bd830502 Do not return or store user agent in lower case as HTTP header fields values are case sensitive as per rfc2616 2018-07-11 13:54:14 +02:00
Gerhard Potgieter 7fa802071e
Merge pull request #20490 from dezio1900/master
Allow items to be changed in wc_save_order_items function
2018-07-11 12:52:36 +02:00
ldybecklee 327fd26c70
Fix product csv exporter get stock value
seems the original get stock value is wrong, but I'm not sure if my change is correct...
what i'm considering is this line:  if ( $product->is_type( 'variation' && 'parent' === $manage_stock ) ) {
2018-07-11 17:28:50 +08:00
Gerhard Potgieter 3cda8c439c Better table matching on multisite, hat tip to @claudiulodro for pointing me in the right direction. 2018-07-11 11:19:10 +02:00
Claudiu Lodromanean 1ef4aa10a0
Merge pull request #20728 from woocommerce/fix/20708
Add edit_theme_options capability to shop manager role
2018-07-10 12:01:13 -07:00
Claudio Sanches 9b7fbff544
Merge pull request #20686 from woocommerce/fix/20673
Replaced query attribute placeholder with actual value for header link.
2018-07-10 15:22:30 -03:00
Claudio Sanches 4fd6dbd880
Merge pull request #20740 from woocommerce/fix/20224-b
Escape sku input properly for quick edit
2018-07-10 15:22:09 -03:00
Claudio Sanches 3ed4dea4bb
Merge pull request #20723 from woocommerce/fix/20707
Only wordwrap plain emails
2018-07-10 15:21:57 -03:00
Claudio Sanches 1c7b2f3100
Merge pull request #20670 from woocommerce/pr/20669
Deleting a product via API should handle children products regardless of type.
2018-07-10 15:16:13 -03:00
Gerhard Potgieter ac09473853 Escape sku input properly for quickedit 2018-07-10 10:56:49 +02:00
Gerhard Potgieter 36b6bd79c0 Add update routines to recreate user roles 2018-07-10 10:30:11 +02:00
Claudiu Lodromanean af98ef66e7
Merge pull request #20730 from woocommerce/fix/20716
Fix log file deletion
2018-07-09 11:35:45 -07:00
Claudiu Lodromanean 24a1ccf5fc
Merge pull request #20732 from woocommerce/update/20709
Outdated templates notice improvements
2018-07-09 11:27:46 -07:00
Claudiu Lodromanean 4d0890bf3b
Merge pull request #20714 from yratof/yratof-patch-item-name
Added filter on item name in quotes
2018-07-09 11:06:45 -07:00
Claudiu Lodromanean e8a2e19b27
Merge pull request #20648 from woocommerce/update/crud-get-image
Custom tables: Get image from ID, not post thumbnail
2018-07-09 11:04:52 -07:00
Gerhard Potgieter 56a9799e6d
Merge pull request #20654 from woocommerce/update/get-terms
Custom tables - remove get terms
2018-07-09 15:27:26 +02:00
Gerhard Potgieter a4e3283b20 Update outdated templates notice 2018-07-09 15:10:49 +02:00
Gerhard Potgieter beaa610cc0 Only load tables for system that is part of current multisite, this avoids displaying all tables in a MS speeding up page load, and also prevent divulding tables on other sites in the MS environment. 2018-07-09 13:48:05 +02:00
Gerhard Potgieter bc3c780b92 PHPCS fixes 2018-07-09 13:04:16 +02:00
Gerhard Potgieter 1fdcf2a238 Fix log file deletion functionality. 2018-07-09 13:01:23 +02:00
Gerhard Potgieter ef2f868b89 Add edit_theme_options capability to shop manager to allow access to customizer for changing WooCommerce settings. 2018-07-09 10:45:48 +02:00
Towhidul Islam 7a957cc130 Convert hardcoded db prefix to dynamic db prefix. Fixes #20718 2018-07-08 10:35:32 +06:00