Claudio Sanches
19e4c7ac7c
Merge pull request #28094 from woocommerce/revert/27289
...
Revert changes introduced in #27289
2020-10-26 12:39:11 -03:00
Roy Ho
c96a642e8a
Merge pull request #28067 from woocommerce/fix/27529
...
Fix: use the correct parameter when calling get_avatar()
2020-10-26 07:46:51 -07:00
Claudio Sanches
c5ff759d61
Revert changes introduced in #27289
2020-10-26 10:26:29 -03:00
Rodrigo Primo
80c3f343a4
Merge pull request #28062 from PlexusLLC/fix-sorting-capability
...
Fix incorrect capability for product sorting link
2020-10-24 15:10:00 -03:00
Rodrigo Primo
1b40e13f99
Merge pull request #27856 from sudoshreyansh/fix/27831
...
Fixed update term message. Issue: #27831
2020-10-24 14:57:06 -03:00
Rodrigo Primo
92153ac3b3
Merge pull request #27723 from alexstewartja/master
...
Introduced fine-grained cultural adaptation for Jamaican-based WooCommerce stores
2020-10-24 14:44:07 -03:00
Rodrigo Primo
3ed300a4aa
Merge pull request #27607 from wpdesk/bugfix/cart-weight-float
...
Fixed cart weight return type.
2020-10-24 14:12:03 -03:00
Claudio Sanches
1427a39be1
Merge pull request #28074 from shahlin/master
...
Minor docblock grammar/typo/casing fixes
2020-10-23 17:33:41 -03:00
Roy Ho
ecd08277f9
Merge pull request #28070 from NicholasMacedo/patch-1
...
Update class-wc-product-variable.php
2020-10-23 13:12:04 -07:00
Shahlin Ibrahim
e06466b2b7
Minor docblock grammar/typo/casing fixes
2020-10-23 17:27:39 +04:00
Nicholas Macedo
815fd01a98
Update class-wc-product-variable.php
...
Fix the typo on line 416 according to Issue #28066
2020-10-22 20:37:36 -04:00
Rodrigo Primo
09faf8ba84
Fix: use the correct parameter when calling get_avatar()
...
`WC_Admin_Dashboard::recent_reviews()` was calling `get_avatar()` passing `$comment->comment_author` which is not one of the list of parameters that the function accepts to get the avatar. As a result, the widget that displays the recent reviews in the admin dashboard was never displaying the avatar of the user that left the review. This commit fixes this issue by passing `$comment->comment_email` instead. I opted to use `$comment->comment_author` as it should be available for reviews left both by authenticated and anonymous users and because getting the comment object wouldn't be so simple (either we need to perform an extra query for each review or deprecate the `woocommerce_report_recent_reviews_query_from` filter).
2020-10-22 17:43:59 -03:00
Rodrigo Primo
e91872c1a8
PHPCS fixes
2020-10-22 17:34:47 -03:00
Rodrigo Primo
6bde9fd8a5
Replace WPCS deprecated syntax
...
Using the WPCS native whitelist comments is deprecated. So this PR just replaces all instances of `// WPCS: XSS ok.` found in `includes/wc-cart-functions.php` with the PHPCS native "// phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped". I found this while working on another issue in the same file.
2020-10-22 16:03:34 -03:00
pjv
f03bfb85da
Fix incorrect capability for product sorting link
...
Fixes #28049
2020-10-22 13:03:35 -05:00
Claudio Sanches
f7ecbbeb35
Prepare default branch to 4.8
2020-10-20 15:20:52 -03:00
Claudio Sanches
631c06020c
Merge pull request #27800 from gbiorczyk/fix/field-label-escaping
...
Escaping output for field label
2020-10-19 20:26:38 -03:00
Rodrigo Primo
0a81188e42
Merge pull request #27987 from woocommerce/php8/fix-required-parameters-after-optional-take-2
...
[PHP 8] Convert optional-before-required parameters into required parameters (take 2)
2020-10-17 09:42:20 -03:00
roykho
e8bcd464db
Update escape based on suggestion
2020-10-16 06:00:34 -07:00
Nestor Soriano
63ced34e2d
Convert optional-before-required arguments to required (take 2)
...
In PHP 8 required parameters after optional parameters in
function/method signatures trigger a deprecation notice. These type
of parameters are pointless since a value needs to always be
provided for them anyway, so they are actually de-facto required.
This commit converts all these not-so-optional parameters into
truly required parameters by removing their default values.
2020-10-16 13:08:31 +02:00
roykho
800cbdbc7e
Add missing escapes
2020-10-15 16:31:56 -07:00
roykho
ace411aacd
Fix billing email being parsed as a URL link when beginning of email contains www closes #25099
2020-10-15 14:25:03 -07:00
Rodrigo Primo
9155a78043
Merge pull request #27858 from Rowayda-Khayri/fixes
...
Add punctuation mark to function's docblock
2020-10-15 15:09:21 -03:00
Néstor Soriano
e4a109f0d1
Merge pull request #27763 from woocommerce/fix/27445
...
Remove protection as we already diff and update only if needed.
2020-10-15 10:01:34 +02:00
Claudio Sanches
e34681dbb4
Merge pull request #27696 from woocommerce/fix/version-race-conditions
...
Fix some race conditions in WC_Install
2020-10-14 20:18:47 -03:00
Claudio Sanches
d211f6ee5c
Merge pull request #27516 from KoolPal/patch-2
...
Renamed Postcode / ZIP to Pin code & renamed State / County to State for India
2020-10-14 19:51:46 -03:00
Claudio Sanches
0b41aff81b
Merge pull request #27546 from KoolPal/patch-1
...
Updated - Added postcode validation for India
2020-10-14 19:25:32 -03:00
Claudio Sanches
e581ffce27
Fixed missing "break"
2020-10-14 19:22:19 -03:00
Claudio Sanches
136c6e2916
Merge pull request #27779 from zzap/patch-2
...
Update properties for Serbia.
2020-10-14 18:09:56 -03:00
Claudio Sanches
23fe4f71bb
Merge pull request #27842 from sudoshreyansh/fix/27839
...
Fixed </strong> closing tag position. Issue: #27839
2020-10-14 18:06:10 -03:00
Claudio Sanches
537ec5d0e9
Merge pull request #27893 from dominic-ks/update-needs-payment-check
...
issue #24631 - Updated needs payment check to use order
2020-10-14 16:29:25 -03:00
Claudio Sanches
27e4288eab
Merge pull request #27934 from woocommerce/remove_get_product_from_item
...
Remove the remaining uses of $order->get_product_from_item()
2020-10-14 16:18:29 -03:00
Claudio Sanches
c530fc0d55
Merge pull request #27908 from woocommerce/fix/template-attachment-ids
...
restore $attachment_ids for product thumbnails template
2020-10-14 15:38:19 -03:00
Claudio Sanches
6ad79cf050
Fixed PHP notice
...
> PHP Notice: compact(): Undefined variable: gallery_image_ids in includes/wc-template-functions.php on line 1487
2020-10-14 15:37:12 -03:00
Claudio Sanches
47a7c6648a
Update includes/wc-template-functions.php
2020-10-14 15:29:24 -03:00
Vedanshu Jain
f65491d1b2
Merge pull request #27898 from woocommerce/add/allow-customise-reset-password-page-title
...
Use "Set Password" page title for lost-password endpoint when setting a password
2020-10-14 23:24:27 +05:30
Claudio Sanches
be4aacee93
Merge pull request #27483 from woocommerce/fix/27475
...
prevent regenerate image filter loop
2020-10-14 14:03:00 -03:00
Claudio Sanches
7d1ff1a655
Merge pull request #27310 from woocommerce/fix/27215
...
Fix deleting a tax class via WP CLI.
2020-10-14 14:00:33 -03:00
Ron Rennick
9cf2d81f60
Merge branch 'master' into fix/template-attachment-ids
2020-10-14 12:40:57 -03:00
Ron Rennick
8ec54fabe0
phpcs fixes
2020-10-14 10:27:58 -03:00
Ron Rennick
cd20044b13
Merge branch 'master' into fix/27215
2020-10-14 10:16:36 -03:00
vedanshujain
c01f32a390
Use default value if formatted value is not available
2020-10-14 14:51:19 +05:30
vedanshujain
8e12de5d3c
Merge branch 'fix/api/229-unit-test' of https://github.com/shiki/woocommerce into fix/api/229
2020-10-14 13:53:03 +05:30
Rua Haszard
95f4b5b81e
restore original comment (related changes are gone)
2020-10-14 12:35:32 +13:00
Rua Haszard
5e3713da75
check password-set user token before redirecting to set password form:
...
- this prevents the password reset process earlier (before the redirect)
- also now shows a notice informing the user that they need to log out
of (other) account
2020-10-14 12:26:51 +13:00
Rua Haszard
1f5601f0fe
ensure lost-password form only resets password for correct user:
...
- if a user is logged in, check their ID matches the ID in the reset
key / token
2020-10-14 12:12:01 +13:00
Rua Haszard
5e5d06cfab
show lost-password form when logged-in user:
...
- in the checkout signup use case, the user may be setting their
password in a logged-in browser session; they need to be able to set an
initial account password
2020-10-14 09:50:36 +13:00
Rua Haszard
b34ad5be5c
improve PHPdocs for get_endpoint_title and related hook:
...
- add @since (original since based on git blame)
- document all params
- add @since for newly-added params
- add docs for woocommerce_endpoint_{$endpoint}_title
2020-10-14 09:50:36 +13:00
Rua Haszard
6032962e59
use "Set password" title for lost-password endpoint for more actions:
...
- 'rp' and 'resetpass' are used in WordPress core
1079647d30/wp-login.php (L913)
- using 'newaccount' for checkout signup case
2020-10-14 09:50:36 +13:00
Rua Haszard
1eb02845aa
support overriding/customising password reset page title via `action`:
...
- get_endpoint_title now takes an extra `action` param
- this also is passed to the relevant hook (as an additional arg)
- woocommerce_endpoint_{$endpoint}_title
- for `lost-password?action=rp`, use `Set password`
- pass action query param through when using get_endpoint_title
2020-10-14 09:50:36 +13:00