Commit Graph

33809 Commits

Author SHA1 Message Date
Rodrigo Primo 44ecb0ec9e Only display the "Paid by customer" section if the order has been paid
This commit changes the condition in the if the statement that decides
whether or not to display the "Paid by customer" section in the order admin
page. Before it, this section was displayed for all orders that
contained one of the following statuses: 'processing', 'completed' or 'refunded'.

The problem with this approach is that offline payment gateways, like
'Cash on Delivery', set the order status to processing when the order is
placed but before the customer pays for it. So the "Paid by customer"
section was being displayed in some cases where the order was not
actually paid yet creating a confusing experience to store managers.

To fix this, this commit also checks for the presence of the
`_date_paid` order meta. If this order meta is present and the order
status corresponds to one of the three statuses listed above, it means that
the order has been paid and we can display the "Paid by customer"
section. If this order meta is not present, we don't display the "Paid
by customer" section.
2020-02-05 16:08:13 -03:00
Peter Fabian 147266f44f Updates to reflect PR feedback. 2020-02-04 21:43:29 +01:00
Rodrigo Primo fb3b977a16 Add test to make sure that negative fees never make order total negative
For some reason unknown to me, the following commit added logic to make
sure that negative fees never make the order total negative: 804feb9333

Probably by accident, commit 4326e39250 changed this logic when `$fees_total += $item->get_total()` was replaced by `$fees_total += $fee_total`:

4326e39250 (diff-9b4164165828b26c4b7aec01c7b17884R1594)

This commit adds a failing test that ensures that the old behavior is
tested. This test needs to be fixed before we merge the changes proposed
in PR #25504.
2020-02-04 15:33:21 -03:00
Rodrigo Primo 08e0936aa6 Improve coverage of WC_Abstract_Order::calculate_totals() test
This commits improves the coverage of the
WC_Abstract_Order::calculate_totals() test by including a fee to the
order used to test the method.
2020-02-04 15:26:52 -03:00
Rodrigo Primo b87d0e26fe Add basic unit test for WC_Abstract_Order::get_total_fees() 2020-02-04 15:13:27 -03:00
Peter Fabian 5001e14086 Renamed Discounts to Coupons. 2020-02-04 18:27:53 +01:00
Peter Fabian d588218eb6 PHPCS 2020-02-03 23:18:12 +01:00
Peter Fabian 12fe0e6815 Corrected tax amount displayed in the summary. 2020-02-03 23:09:59 +01:00
Peter Fabian f9c9498e7c Replaced deprecated call with a substitute function. 2020-02-03 23:09:19 +01:00
Peter Fabian 248e69960b Merge branch 'master' into update/order-detail-summary 2020-01-30 17:41:32 +01:00
Peter Fabian ec8d477b09 PHPCS fix. 2020-01-30 17:09:33 +01:00
Claudio Sanches 1fc001bd1b Fixed incorrect entry in changelog 2020-01-30 13:09:11 -03:00
Claudio Sanches 603c0e30ab
Merge pull request #25535 from woocommerce/update/changelog
3.9.1 changelog
2020-01-30 13:06:37 -03:00
Claudio Sanches 18dd970473 3.9.1 changelog 2020-01-30 13:06:01 -03:00
Peter Fabian a9a64fcee0
Merge pull request #25482 from woocommerce/fix/cart-e2e-test
Fix failing cart e2e test: fix setup wizard logic if new onboarding is presented
2020-01-30 12:51:56 +01:00
Julia Amosova 3dfc8f3dc5 Remove unnecessary 2nd setup wizard flow for the new onboarding 2020-01-30 11:29:28 +00:00
Julia Amosova 18d93e321a Update setup wizard test logic 2020-01-30 10:38:10 +00:00
Julia Amosova 1a46497042
Merge pull request #25295 from woocommerce/update/selenium-cleanup
[E2E] Remove code related to e2e tests that were previously run using Selenium WebDriver
2020-01-30 10:11:05 +00:00
Christopher Allford ceeba16014
Merge pull request #24919 from TimBHowe/fix/20921
Fix/20921 - Throw error for invalid character in flat rate cost.
2020-01-29 13:32:49 -08:00
Claudio Sanches 641a4c1890
Merge pull request #25087 from woocommerce/add/post-merge
Introduced GIT post-merge hook to update NPM and Composer dependencies
2020-01-29 18:24:08 -03:00
Rodrigo Primo 1793fdf682
Merge pull request #25522 from woocommerce/update/maxmind-title
Simplify MaxMind integration title
2020-01-29 17:17:10 -03:00
Claudio Sanches 966171c6f4
Merge pull request #25511 from woocommerce/renovate/woocommerce-woocommerce-rest-api-1.x
Update dependency woocommerce/woocommerce-rest-api to v1.0.7
2020-01-29 15:47:13 -03:00
Claudio Sanches 2ec4492074 Simplify MaxMind integration title 2020-01-29 13:43:27 -03:00
Rodrigo Primo 3d97718094
Merge pull request #25485 from woocommerce/update/25336
Allow filter file path on WC_Download_Handler::download_product()
2020-01-28 20:41:21 -03:00
Renovate Bot 4389ef5b40
Update dependency woocommerce/woocommerce-rest-api to v1.0.7 2020-01-28 21:55:26 +00:00
Claudio Sanches cacf5c4f91
Merge pull request #25472 from woocommerce/fix/25463
Apply rounding only if value is integer to display "-" when needed.
2020-01-28 18:09:22 -03:00
Rodrigo Primo 151984a9cd
Merge pull request #25489 from woocommerce/fix/25338
Check if wp_delete_user() exists before use
2020-01-28 17:34:30 -03:00
Rodrigo Primo 6d96acbcce
Merge pull request #25496 from gerdneuman/patch-1
Fix wrong context help for translators
2020-01-28 17:29:28 -03:00
Claudio Sanches d64cc69cd7
Merge pull request #25507 from woocommerce/fix/25490
Fixed fatal error on the thank you page if order is not specified.
2020-01-28 13:12:41 -03:00
TimBHowe f488f46b37 remove the pattern constraint on the flatrate input in the setup wiz 2020-01-28 11:01:13 -05:00
TimBHowe e7a575222a Updated if statment to allow 0 values 2020-01-28 10:44:37 -05:00
TimBHowe d377f002aa Added pattern attribute to the flat rate cost input field to only allow US and EU currency formating 2020-01-28 10:44:37 -05:00
TimBHowe 8b71dc0abb Updated the wc_setup_shipping_save() function to sanitize the flatrate cost input 2020-01-28 10:44:36 -05:00
Tim Howe 3b5e44ccf1 Added a call to the evaluate_cost function in the sanitize_cost function to throw an exception if there is an illegal character in the input. 2020-01-28 10:44:35 -05:00
Peter Fabian 30dde8f53c The JS might still be needed as merchants can manage/change settings even for a disabled gateway. 2020-01-28 14:13:03 +01:00
Peter Fabian 217c9d2adc Fix incorrect comment. 2020-01-28 14:10:10 +01:00
Peter Fabian 8600987591 Functions are not needed when the gateway is disabled. 2020-01-28 14:07:50 +01:00
Peter Fabian dc9d4496e9 Require order object to prevent error. 2020-01-28 14:06:02 +01:00
David Levin ee2c6b8096 Change net payment to net total 2020-01-27 21:10:11 -08:00
David Levin 3c92aacfcb update shipping methods 2020-01-27 19:22:04 -08:00
Rodrigo Primo 47d6311d1e
Merge pull request #25484 from woocommerce/fix/25478
Prevent empty notices to get added
2020-01-27 18:04:47 -03:00
gerdneuman 8057946904
Fix wrong context help for translators
I found this very confusing at https://translate.wordpress.org/projects/wp-plugins/woocommerce/stable/de/default/?filters%5Bterm%5D=ending+in&filters%5Buser_login%5D=&filters%5Bstatus%5D=current_or_waiting_or_fuzzy_or_untranslated&filter=Filter&sort%5Bby%5D=priority&sort%5Bhow%5D=desc that the comment is wrong for translator.

Here's a fix.
2020-01-26 17:55:17 +01:00
Claudio Sanches e109258583 Check if wp_delete_user() exists before use 2020-01-24 18:49:21 -03:00
Claudio Sanches 42864cdfdb Fixed coding standards 2020-01-24 15:01:12 -03:00
Claudio Sanches 86d59257f4 Introduced woocommerce_download_product_filepath filter 2020-01-24 15:00:55 -03:00
Julia Amosova 0a5c866bc4 Remove taking screenshots sent to AWS on failed tests 2020-01-24 17:17:52 +00:00
Julia Amosova d4c8719d1f Remove the process of building legacy e2e test site 2020-01-24 17:05:18 +00:00
Julia Amosova eb92d35d96 Remove DB (used for the initial setup) that is no longer needed 2020-01-24 17:05:17 +00:00
Claudio Sanches 30e0c6ad87 Prevent empty notices to get added 2020-01-24 13:31:05 -03:00
Julia Amosova 2415cf1952 Fix setup wizard logic if new onboarding is presented 2020-01-24 14:37:27 +00:00