Commit Graph

37329 Commits

Author SHA1 Message Date
Rodrigo Primo 7830562fc7 Remove PHP 7.4 from the Travis job that runs E2E tests
This should reduce in about ten seconds (https://travis-ci.org/github/woocommerce/woocommerce/jobs/736437593#L198) the time to run this Travis job. PHP 7.4 is not installed by default in the image user by Travis and it is not needed to run the E2E tests.
2020-10-17 11:54:30 -03:00
Rodrigo Primo 0a81188e42
Merge pull request #27987 from woocommerce/php8/fix-required-parameters-after-optional-take-2
[PHP 8] Convert optional-before-required parameters into required parameters (take 2)
2020-10-17 09:42:20 -03:00
roykho 2bad75a87c
Fix checkout page not displaying visual blocking when place order is clicked closes #27656 2020-10-16 16:02:25 -07:00
Rodrigo Primo 17471f8f66 Stop installing PHPCS globally in the Travis build job
PHPCS is already installed as a project dependency (we run `composer
install` for each build job) so there is no need to install it as a
global package in `tests/bin/phpcs.sh`.
2020-10-16 16:37:05 -03:00
Rodrigo Primo eaef2409bd Use phpcs installed locally instead of globally
This is an attempt to fix the PHPCS Travis build job that started
failing with the following error:

```
Running Code Sniffer.
tests/bin/phpcs.sh: line 14: phpcs: command not found
The command "bash tests/bin/phpcs.sh" exited with 127.
```

(https://travis-ci.org/github/woocommerce/woocommerce/jobs/736440739#L508)
2020-10-16 16:36:57 -03:00
Ron Rennick 3b1481bb01 expand e2e-utils readme, simplify exports 2020-10-16 16:25:23 -03:00
Claudio Sanches ad59064c69
Merge pull request #27983 from woocommerce/fix/issue-25099
Fix billing email being parsed as a URL link when beginning of email …
2020-10-16 14:16:57 -03:00
Rodrigo Primo 9ac6d54960
Merge pull request #27469 from woocommerce/renovate/automattic-jetpack-constants-1.x
Update dependency automattic/jetpack-constants to v1.5.0
2020-10-16 14:07:02 -03:00
Ron Rennick ad1e5a180f
Merge pull request #27301 from woocommerce/update/writing-e2e-tests-readme
Add guide for writing e2e tests in README
2020-10-16 12:33:34 -03:00
Julia Amosova ff67a7c1ce Add note about test locations in WC Core and other projects. 2020-10-16 11:27:00 -04:00
Julia Amosova bd5b65426f Update README with more details on how to write e2e tests. 2020-10-16 11:20:33 -04:00
Julia Amosova 8c094daceb Add guide for writing e2e tests in README 2020-10-16 11:20:24 -04:00
roykho e8bcd464db
Update escape based on suggestion 2020-10-16 06:00:34 -07:00
Rodrigo Primo f7dd2c0ad3
Merge pull request #27164 from bahiirwa/locales
Add i18n locale information for Uganda, Kenya and Tanzania.
2020-10-16 09:57:55 -03:00
Nestor Soriano 63ced34e2d Convert optional-before-required arguments to required (take 2)
In PHP 8 required parameters after optional parameters in
function/method signatures trigger a deprecation notice. These type
of parameters are pointless since a value needs to always be
provided for them anyway, so they are actually de-facto required.

This commit converts all these not-so-optional parameters into
truly required parameters by removing their default values.
2020-10-16 13:08:31 +02:00
Renovate Bot a7696c7392
Update dependency automattic/jetpack-constants to v1.5.0 2020-10-16 10:31:13 +00:00
Nestor Soriano 042e2cd0bb Fixes in the dependency injection engine for PHP 8 compatibility
- One dummy class used for tests had a 'final private' method, this
  is not allowed in PHP 8 and so the method is now just 'private'.

- The AbstractServiceProvider class was using
  ReflectionParameter::getClass. This is deprecated in PHP8 and thus
  that usage has been replaced with an utility method that uses
  the recommended replacement.
2020-10-16 11:31:26 +02:00
Néstor Soriano 9aec324a89
Merge pull request #27904 from woocommerce/renovate/league-container-3.x
Update dependency league/container to v3.3.3
2020-10-16 11:17:22 +02:00
roykho 800cbdbc7e
Add missing escapes 2020-10-15 16:31:56 -07:00
Claudio Sanches 51912c659d
Merge pull request #27982 from rodrigoprimo/update/improve-travis-performance
Improve Travis build performance by running `npm install` only when needed
2020-10-15 19:56:55 -03:00
Claudio Sanches 6466db8234
Merge pull request #27977 from woocommerce/update/travis-build-jobs
Add the WP nightly build job to the allow_failures list
2020-10-15 19:54:55 -03:00
roykho ace411aacd
Fix billing email being parsed as a URL link when beginning of email contains www closes #25099 2020-10-15 14:25:03 -07:00
Rodrigo Primo 8e893a16c0 Improve Travis build performance by running `npm install` only when needed
This commit changes the .travis.yml file to run `npm install` (and two associated commands) only when running the build job that executes the E2E tests. Running `npm install` takes about 160 seconds to complete and, before this commit, we were running it for all build jobs unnecessarily.
2020-10-15 18:17:47 -03:00
Rodrigo Primo 0656ad5e6c
Merge branch 'master' into locales 2020-10-15 15:21:44 -03:00
Rodrigo Primo 9155a78043
Merge pull request #27858 from Rowayda-Khayri/fixes
Add punctuation mark to function's docblock
2020-10-15 15:09:21 -03:00
Rodrigo Primo 7599517e91
Merge pull request #27965 from woocommerce/fix/27874
switch to api package, bump utils package version
2020-10-15 15:05:43 -03:00
Ron Rennick dd6d460fec update e2e-environment readme 2020-10-15 14:53:21 -03:00
Rodrigo Primo dbde601d22
Merge pull request #27976 from woocommerce/add/e2e-environment-changelog
add e2e-environment package changelog
2020-10-15 14:48:06 -03:00
Rodrigo Primo 9bf1c15c75
Merge pull request #27197 from woocommerce/renovate/eslint-plugin-jest-23.x
Update dependency eslint-plugin-jest to v23.20.0
2020-10-15 14:46:10 -03:00
Rodrigo Primo 8d0b03632d
Merge pull request #27824 from woocommerce/renovate/config-3.x
Update dependency config to v3.3.2
2020-10-15 14:36:35 -03:00
Rodrigo Primo 0c6f7cb3fc Add the WP nightly build job to the allow_failures list
This commit adds the Travis build job that runs using WP nightly to the
list of jobs that are allowed to fail. Two days ago a change
(fa5a6c8622) was
introduced to WP nightly that broke hundreds of our unit tests. I'm
suggesting we move this build job to the list of jobs that are allowed
to fail while we work on a fix for this problem either on our side or on
WP core side. Having the build always failing due to a known issue in a yet to be released WP version has the potential to hide other more important failures.
2020-10-15 14:24:51 -03:00
Rodrigo Primo 16d839ef62
Merge pull request #27195 from woocommerce/renovate/babel-monorepo
Update babel monorepo
2020-10-15 14:18:35 -03:00
Ron Rennick c3f934ad21 add e2e-environment package changelog 2020-10-15 14:14:22 -03:00
Ron Rennick 5815e5cf48
Merge pull request #27914 from woocommerce/fix/e2e-container-check
Only attempt to run E2E tests if testing host is ready
2020-10-15 13:44:55 -03:00
Ron Rennick f0e6e1761c
Merge pull request #27913 from woocommerce/fix/27820
add test:e2e-debug command
2020-10-15 13:44:32 -03:00
Ron Rennick 0a7c0dc7fc
Merge pull request #27790 from woocommerce/fix/27787
Expose automattic/puppeteer-utils in e2e-environment
2020-10-15 09:52:52 -03:00
Albert Juhé Lluveras b02f4ec62b Update WooCommerce Blocks package to 3.6.0 2020-10-15 10:46:20 +02:00
Néstor Soriano e4a109f0d1
Merge pull request #27763 from woocommerce/fix/27445
Remove protection as we already diff and update only if needed.
2020-10-15 10:01:34 +02:00
Renovate Bot 25034d000a
Update dependency eslint-plugin-jest to v23.20.0 2020-10-15 01:40:35 +00:00
Claudio Sanches 5daf39e169
Merge pull request #27010 from senff/fix/27009
CSS fix for issue 27009
2020-10-14 21:28:46 -03:00
Claudio Sanches 87ee7167eb
Merge pull request #27968 from woocommerce/fix/issue-27532
Tweak CSS to properly display product reviews in activity widget
2020-10-14 21:07:14 -03:00
Claudio Sanches e34681dbb4
Merge pull request #27696 from woocommerce/fix/version-race-conditions
Fix some race conditions in WC_Install
2020-10-14 20:18:47 -03:00
Claudio Sanches d211f6ee5c
Merge pull request #27516 from KoolPal/patch-2
Renamed Postcode / ZIP to Pin code & renamed State / County to State for India
2020-10-14 19:51:46 -03:00
Claudio Sanches 0b41aff81b
Merge pull request #27546 from KoolPal/patch-1
Updated - Added postcode validation for India
2020-10-14 19:25:32 -03:00
Claudio Sanches e581ffce27
Fixed missing "break" 2020-10-14 19:22:19 -03:00
Claudio Sanches d06e4dcddd
Merge pull request #27542 from woocommerce/renovate/grunt-1.x
Update dependency grunt to v1.3.0
2020-10-14 19:21:01 -03:00
Claudio Sanches e58cc1bcb1
Merge pull request #27767 from woocommerce/fix/remove-duplicated-code
Remove duplicated CSS content
2020-10-14 19:20:03 -03:00
roykho 233f38fa67
Tweak CSS to properly display product reviews in activity widget closes #27532 2020-10-14 14:37:28 -07:00
Claudio Sanches 136c6e2916
Merge pull request #27779 from zzap/patch-2
Update properties for Serbia.
2020-10-14 18:09:56 -03:00
Claudio Sanches 0819ea06c9
Merge pull request #27778 from zzap/patch-1
Add Serbia districts.
2020-10-14 18:08:19 -03:00