Peter Fabian
59c47c4407
Refactored line item logic
...
- prepare_line_items is not used as a test anymore, it only updates line items
- add_line_item is not used as a test anymore, only adds line items
- added method line_items_valid to test for valid line items
- shipping tax inclusion test moved to get_shipping_cost_line_item to encapsulate shipping tax-related logic
2018-03-28 11:04:34 +02:00
Peter Fabian
f39e8e3900
Removed incorrect comment
2018-03-27 16:28:25 +02:00
Peter Fabian
5eda49f98a
Line item logic refactored
...
Renamed function get_non_line_item_args
Documentation updates
...all part of code review fixes
2018-03-27 15:55:03 +02:00
Peter Fabian
f6d748a812
Fixed PHPCS violation
2018-03-26 13:31:29 +02:00
Peter Fabian
88588eccbc
Code duplication removed
...
Added test for non line item agrument presence
Fixed incorrect comment
2018-03-26 13:05:55 +02:00
Peter Fabian
e19d64e51e
Fixed PHPCS violations
2018-03-26 11:00:28 +02:00
Peter Fabian
26144afbc6
Test request length after applying filter
...
- added default value to get_line_item_args to not break interface
- smaller code review updates
2018-03-23 17:22:09 +01:00
Peter Fabian
59af63e642
Merge branch 'master' into fix/19404
2018-03-23 09:36:15 +01:00
Claudiu Lodromanean
d4ef90bf91
Merge pull request #19495 from woocommerce/fix/emails-class-phpcs
...
Fixed includes/class-wc-emails.php PHPCS violations
2018-03-22 13:27:21 -07:00
Claudiu Lodromanean
8048afe4ce
Merge pull request #19498 from woocommerce/fix/frontend-scripts-class-phpcs
...
Fixed includes/class-wc-frontend-scripts.php PHPCS violations
2018-03-22 13:25:12 -07:00
Claudiu Lodromanean
d5e98e8d08
Merge pull request #19497 from woocommerce/fix/product-classes-phpcs
...
Fixed product classes PHPCS violations
2018-03-22 13:22:34 -07:00
Peter Fabian
fda6421dee
Fixed compatibility with older PHP versions, removed superfluous asserts.
2018-03-22 20:42:19 +01:00
Claudio Sanches
027789271d
Fixed includes/class-wc-frontend-scripts.php PHPCS violations
2018-03-22 16:01:03 -03:00
Claudio Sanches
930591808b
Fixed includes/class-wc-product-variation.php PHPCS violations
2018-03-22 15:49:01 -03:00
Claudio Sanches
b2e33b3fb9
Fixed includes/class-wc-product-variable.php PHPCS violations
2018-03-22 15:47:50 -03:00
Claudio Sanches
8470a691a7
Fixed includes/class-wc-product-simple.php PHPCS violations
2018-03-22 15:43:51 -03:00
Claudio Sanches
50c0a34dec
Fixed includes/class-wc-product-query.php PHPCS violations
2018-03-22 15:41:53 -03:00
Claudio Sanches
dfeb867a04
Fixed includes/class-wc-product-grouped.php PHPCS violations
2018-03-22 15:37:29 -03:00
Claudio Sanches
73a56469ef
Fixed includes/class-wc-product-factory.php PHPCS violations
2018-03-22 15:36:07 -03:00
Claudio Sanches
6eada732b8
Fixed includes/class-wc-product-external.php PHPCS violations
2018-03-22 15:26:09 -03:00
Claudio Sanches
475e0c734f
Fixed includes/class-wc-product-download.php PHPCS violations
2018-03-22 15:10:22 -03:00
Claudio Sanches
809ca5e0fc
Fixed includes/class-wc-product-attribute.php PHPCS violations
2018-03-22 15:07:06 -03:00
Claudio Sanches
a529e1fdf3
Fixed includes/class-wc-emails.php PHPCS violations
2018-03-22 14:54:16 -03:00
Mike Jolley
db9e66e743
Merge pull request #19481 from woocommerce/fix/payment-classes-phpcs
...
Fixed payment main classes PHPCS violations
2018-03-22 15:11:13 +00:00
Mike Jolley
d40e09b3c9
Merge pull request #19484 from woocommerce/fix/shipping-classes-phpcs
...
Fixed shipping classes PHPCS violations
2018-03-22 15:08:11 +00:00
Mike Jolley
66a5895645
Merge pull request #19483 from woocommerce/fix/posts-classes-phpcs
...
Fixed post classes PHPCS violations
2018-03-22 15:07:45 +00:00
Claudio Sanches
e79012e7e3
Fixed a typo
2018-03-22 12:06:36 -03:00
Mike Jolley
28a4e88811
Merge pull request #19482 from woocommerce/fix/remove-nonce-necessary-bool
...
Removed obvious boolean results
2018-03-22 14:56:11 +00:00
Peter Fabian
27a309d2df
Removed line item limit and make sure the URL is shorter than 2083 characters
...
- removed limit to 9 line items per Paypal order
- if the request URL with all line items will be longer than 2083 characters, send it as one line item
- fix the character limit function to account for URL encoding happening in http_build_query
2018-03-22 15:39:30 +01:00
Claudio Sanches
fd57c1c596
Fixed includes/class-wc-shipping-rate.php PHPCS violations
2018-03-21 20:58:20 -03:00
Claudio Sanches
996d3decfe
Fixed file and class dockblock
2018-03-21 20:54:10 -03:00
Claudio Sanches
39f1c3e8fc
Fixed coding standards
2018-03-21 20:53:59 -03:00
Claudio Sanches
7b1fc4c8e8
Fixed includes/class-wc-post-types.php PHPCS violations
2018-03-21 20:50:40 -03:00
Claudio Sanches
ce8033ddf6
Fixed includes/class-wc-post-data.php PHPCS violations
2018-03-21 20:44:35 -03:00
Claudio Sanches
b0617a13c4
Removed unnecessary ternary operators
2018-03-21 20:05:19 -03:00
Claudio Sanches
0660a50e07
Removed obvious boolean results
2018-03-21 19:57:10 -03:00
Claudio Sanches
72d0b448f6
Fixed includes/class-wc-payment-tokens.php PHPCS violations
2018-03-21 19:45:27 -03:00
Claudio Sanches
d14615a6f7
Fixed includes/class-wc-payment-gateways.php PHPCS violations
2018-03-21 19:40:47 -03:00
Mike Jolley
dc7aa30694
Merge pull request #19467 from woocommerce/fix/some-includes-classes-phpcs
...
Fixed PHPCS violations in some classes on includes directory
2018-03-21 10:39:18 +00:00
Mike Jolley
bc7846c412
Merge pull request #19468 from woocommerce/fix/order-classes-phpcs
...
Fixed order classes PHPCS violations
2018-03-21 10:33:58 +00:00
Claudio Sanches
a7692478b0
Fixed includes/class-wc-order-item.php PHPCS violations
2018-03-21 00:56:59 -03:00
Claudio Sanches
583378cf7b
Fixed includes/class-wc-order-item-tax.php PHPCS violations
2018-03-21 00:52:55 -03:00
Claudio Sanches
eedc8c57e5
Improved class description
2018-03-21 00:50:30 -03:00
Claudio Sanches
949514fe75
Fixed includes/class-wc-order-item-product.php PHPCS violations
2018-03-21 00:49:45 -03:00
Claudio Sanches
d03e5a5f6c
Fixed includes/class-wc-order-item-shipping.php coding standards
2018-03-21 00:46:32 -03:00
Claudio Sanches
51a06da91d
Fixed includes/class-wc-order-item.php PHPCS violations
2018-03-21 00:45:44 -03:00
Claudio Sanches
9a55d16f44
Fixed includes/class-wc-order.php PHPCS violations
2018-03-21 00:44:44 -03:00
Claudio Sanches
ddac79152a
Fixed includes/class-wc-order-item-meta.php PHPCS violations
2018-03-21 00:43:54 -03:00
Claudio Sanches
e70f278123
Fixed includes/class-wc-order-item-fee.php PHPCS violations
2018-03-21 00:39:37 -03:00
Claudio Sanches
806c0d7a6d
Fixed includes/class-wc-order-item-coupon.php PHPCS violations
2018-03-21 00:33:44 -03:00