Commit Graph

25273 Commits

Author SHA1 Message Date
Steve Grunwell 86c449accf Add missing hard-stops and parentheses for new objects being instantiated, enabling tests/unit-tests/api/system-status.php to pass coding standard checks 2018-01-17 22:13:57 +00:00
Steve Grunwell fa42eb0edf Temporarily disable the WordPress.NamingConventions.ValidVariableName.NotSnakeCaseMemberVar sniff at the end of the test_get_system_status_info_theme() method.
The wp_get_theme() function returns a WP_Theme object, which uses uppercase property names, which goes against typical WordPress conventions.

This uses the more modern (read: PHP_CodeSniffer 3.2.0+) syntax for temporarily disabling sniffs. For more details, please see https://github.com/squizlabs/PHP_CodeSniffer/wiki/Advanced-Usage#ignoring-parts-of-a-file.
2018-01-17 22:11:32 +00:00
Steve Grunwell 8c3fd0c75f Don't flag instances of print_r() within the tests/ directory.
In some cases, calls like `print_r( $data, true )` (return the printed array as a string) can be helpful for providing context if/when a test fails.
2018-01-17 22:10:56 +00:00
Steve Grunwell 6b79619983 Add a file-level docblock for the WC_Tests_REST_System_Status class 2018-01-17 22:10:55 +00:00
Steve Grunwell 1a0fd86de5 *WHITESPACE ONLY* Fix alignment of code to satisfy PHP_CodeSniffer 2018-01-17 21:50:26 +00:00
Steve Grunwell b7825faa39 Don't hold the test suite to the same naming conventions as WordPress/WooCommerce. 2018-01-17 21:50:18 +00:00
Steve Grunwell ff0e200ae5 Introduce the woocommerce_rest_system_status_tool_executed action, which fires after one of the WooCommerce REST system status tools is executed. 2018-01-17 21:48:23 +00:00
Claudiu Lodromanean dbb6e2716d
Merge pull request #18497 from woocommerce/update/setup-wizard-activate-but-disable-ppec-by-default
Setup wizard: activate but don't enable PPEC by default
2018-01-17 11:31:55 -08:00
Paul Dechov 3dee78ea54 Tweak variable name 2018-01-17 12:43:44 -05:00
Claudiu Lodromanean 9236f7b7d4
Merge pull request #18496 from ragulka/action-button-style-tweaks
Prevent visual "border jump" when hovering over grouped action buttons
2018-01-17 07:09:40 -08:00
Paul Dechov dc884c5e2f Refactor so as to leave 'enabled' setting alone in case gateway was already enabled 2018-01-16 16:15:30 -05:00
Paul Dechov fcf3d368f2 Setup wizard: if selected, activate but disable PPEC gateway by default 2018-01-16 16:14:35 -05:00
ragulka 2a2418e222 tweak grouped action button margins 2018-01-16 12:15:04 +02:00
Claudiu Lodromanean 3b895bd0a9
Merge pull request #18490 from woocommerce/fix/cart-hash-naming
cart_hash_key param
2018-01-15 10:13:55 -08:00
Claudiu Lodromanean 99f58c4c56
Merge pull request #18488 from woocommerce/fix/18474
Protocol-relative paths are absolute.
2018-01-15 08:28:42 -08:00
Claudiu Lodromanean 6fa23069a4
Merge pull request #18484 from woocommerce/fix/18481
Adding view_items string
2018-01-15 08:15:25 -08:00
Claudiu Lodromanean 1d2c27df6f
Merge pull request #18485 from ragulka/order-status-badge-styling
Gracefully handle order status text overflow
2018-01-15 08:13:50 -08:00
Mike Jolley 431b95dade cart_hash_key param 2018-01-15 16:03:27 +00:00
Mike Jolley 9a2b051d74 Relative paths are absolute. 2018-01-15 15:41:31 +00:00
Mike Jolley 0006d575a6
Merge pull request #18486 from woocommerce/update-japanese-prefectures-coy
Spelling correction
2018-01-15 15:37:46 +00:00
John Coy 0b0ce465f2 Spelling correction
Japanese prefecture Hokkai-do required hyphen to speparate prefecture from prefecture type.
2018-01-15 09:17:59 -06:00
ragulka a8d8d7d27c gracefully handle overly long order statuses 2018-01-15 16:55:26 +02:00
Mike Jolley 93bac7ce04 Adding view_items string 2018-01-15 14:53:26 +00:00
Mike Jolley 73b5b1c058
Merge pull request #18479 from shivapoudel/main-plugin-file
WooCommerce sniffs for main plugin file
2018-01-15 11:00:50 +00:00
Mike Jolley 4901caa729
Merge pull request #18478 from shivapoudel/cli
Use dirname rather than __DIR__ and use parenthesis for WC_CLI
2018-01-15 11:00:14 +00:00
Shiva Poudel 7a4debede6 WooCommerce sniffs for main plugin file 2018-01-15 11:13:59 +05:45
Shiva Poudel e17d2819ea Use dirname rather than __DIR__ and use parenthesis for WC_CLI 2018-01-15 11:06:53 +05:45
Claudio Sanches dff5fefe73
Merge pull request #18460 from woocommerce/fix/18448
Revert RTL changes in price formatting
2018-01-12 14:28:36 -02:00
Claudiu Lodromanean bb47315fdd
Merge pull request #18459 from woocommerce/fix/18451
Auth screen escaping
2018-01-12 07:26:54 -08:00
Claudiu Lodromanean 544d181538
Merge pull request #18458 from woocommerce/update/storefront-wizard
Update wizard wording
2018-01-12 07:24:42 -08:00
Mike Jolley dbdc3af9e5 Tests 2018-01-12 14:20:39 +00:00
Mike Jolley 7a7995f697 Revert price formatting changes which break in RTL 2018-01-12 14:16:18 +00:00
Claudio Sanches 7290d6e42e Fixed test string #18430 2018-01-12 11:59:17 -02:00
Mike Jolley ac7bdd1a56 Fix escaping and PHPCS 2018-01-12 13:04:26 +00:00
Mike Jolley 4997e3f939
Merge pull request #18444 from woocommerce/update/readme-contributors
Updates the line inviting everyone to join
2018-01-12 12:32:54 +00:00
Mike Jolley 243c664030 Wording update 2018-01-12 12:29:22 +00:00
Mike Jolley 89c888d654 phpcs 2018-01-12 11:33:26 +00:00
Claudio Sanches b2129b0c44
Merge pull request #18446 from woocommerce/update/readme-storefront-link
Update Storefront link to match other link
2018-01-11 22:32:50 -02:00
Claudio Sanches 1c6529cc83
Merge pull request #18442 from dougaitken/importer-link
add importer link
2018-01-11 22:32:15 -02:00
Claudio Sanches 81dc3cf9bb
Merge pull request #18450 from liquidweb/feature/remove-compat-check-for-tests-dir
Exclude the /tests/ directory from PHP Compatibility checks
2018-01-11 22:31:27 -02:00
Steve Grunwell 4cded5e9aa Exclude the /tests/ directory from PHP Compatibility checks
The composer.json file in WooCommerce specifies PHPUnit version 6.2.3 as a development dependency; that version of PHPUnit sets PHP 7.0 as the minimum PHP version, effectively making the minimum development version for WooCommerce to be PHP 7.0 (hooray!).

With a more modern version of PHP as the minimum requirement for developers, the code that isn't distributed with the plugin (e.g. the /tests/ directory) doesn't necessarily need to adhere to PHP 5.2-compatible coding standards. This commit removes the /tests/ directory from the scope of the PHP Compatibility checks, enabling the test suite to leverage modern (relative to PHP 5.2, anyway) features like closures, short-array syntax, and namespaces. Embracing more modern PHP in the test suite also opens up the possibilities of using libraries like Faker to populate dummy data, rather than the hard-coded helpers that exist now.

An example test enabled by this change: developers can now use closures for filter callbacks.

    add_filter( 'some_filter', function () {
        return 'the filtered value';
    }

    $this->assertEquals( 'the filtered value', my_function() );

Without a closure, this test would need to either write a one-off method in the test class or hack around it with static properties to configure the expected filter response.
2018-01-11 23:17:22 +00:00
Jonathan Belcher 918b7a4bc2
Update Storefront link to match other link
Update Storefront link to match other link to match the other link in this document on line 135
2018-01-11 15:06:10 -05:00
Jonathan Belcher 42cdea1415
Updates the line inviting everyone to join 2018-01-11 13:55:15 -05:00
claudiulodro 1d7021bbaf Bump version for RC 2018-01-11 09:13:07 -08:00
claudiulodro 32b85885b4 Recompile assets 2018-01-11 09:10:29 -08:00
Claudiu Lodromanean 16425f09aa
Merge pull request #18440 from woocommerce/fix/18437-1
Fixed number of args passed to woocommerce_order_item_meta
2018-01-11 09:08:17 -08:00
Doug Aitken 34242438f4 add importer link 2018-01-11 17:07:28 +00:00
Claudiu Lodromanean c51f199c22
Merge pull request #18439 from ryanr14/master
Updates & renames all dummy data to sample data.
2018-01-11 08:56:11 -08:00
Claudio Sanches cac9e0d872 Fixed number of args passed to woocommerce_order_item_meta
Part of #18437
2018-01-11 14:47:19 -02:00
Ryan Ray b3af5c808d Updates & renames all dummy data to sample data. 2018-01-11 11:39:51 -05:00