Ron Rennick
9d47a1c072
simplify e2e-environment exports
2020-10-21 16:17:10 -03:00
Ron Rennick
e91a09f302
remove remaining webalias fragments
2020-10-21 15:47:09 -03:00
Ron Rennick
5e2e01e7b8
add Nightly message to log, bump Travis
2020-10-21 13:25:23 -03:00
Ron Rennick
7ebfdbeb0e
add support for custom container initialization script
2020-10-21 10:53:48 -03:00
Ron Rennick
7a5cad3f99
variation test works to last uncommented step
2020-10-20 19:43:07 -03:00
Ron Rennick
bf410cc44e
use checkbox object for checking/unchecking
2020-10-20 17:21:34 -03:00
Ron Rennick
894dceee95
Fixes needed for variable product E2E test
...
- Jest/Puppeteer sometimes will not find an element on page load when that element is outside the initial viewport
- There were duplicate .variation_tab classes which confused Jest/Puppeteer
- Add function for opening and verifying new product page
- Update test sequence for changes in flow in markup and Jest/Puppeteer
2020-10-20 11:25:36 -03:00
Claudio Sanches
f7e9c1bfb7
Merge pull request #27995 from rodrigoprimo/fix/phpcs-travis
...
Fix the Travis build job that runs PHPCS
2020-10-20 10:14:39 -03:00
Claudio Sanches
139df7bdaa
Merge pull request #27986 from woocommerce/php8/fixes-in-dependency-injection-container
...
[PHP 8] Fixes in the dependency injection engine for PHP 8 compatibility
2020-10-19 20:22:35 -03:00
Ron Rennick
503e898307
use direct exports
2020-10-19 11:32:28 -03:00
Rodrigo Primo
17471f8f66
Stop installing PHPCS globally in the Travis build job
...
PHPCS is already installed as a project dependency (we run `composer
install` for each build job) so there is no need to install it as a
global package in `tests/bin/phpcs.sh`.
2020-10-16 16:37:05 -03:00
Rodrigo Primo
eaef2409bd
Use phpcs installed locally instead of globally
...
This is an attempt to fix the PHPCS Travis build job that started
failing with the following error:
```
Running Code Sniffer.
tests/bin/phpcs.sh: line 14: phpcs: command not found
The command "bash tests/bin/phpcs.sh" exited with 127.
```
(https://travis-ci.org/github/woocommerce/woocommerce/jobs/736440739#L508 )
2020-10-16 16:36:57 -03:00
Ron Rennick
3b1481bb01
expand e2e-utils readme, simplify exports
2020-10-16 16:25:23 -03:00
Julia Amosova
ff67a7c1ce
Add note about test locations in WC Core and other projects.
2020-10-16 11:27:00 -04:00
Julia Amosova
bd5b65426f
Update README with more details on how to write e2e tests.
2020-10-16 11:20:33 -04:00
Julia Amosova
8c094daceb
Add guide for writing e2e tests in README
2020-10-16 11:20:24 -04:00
Nestor Soriano
042e2cd0bb
Fixes in the dependency injection engine for PHP 8 compatibility
...
- One dummy class used for tests had a 'final private' method, this
is not allowed in PHP 8 and so the method is now just 'private'.
- The AbstractServiceProvider class was using
ReflectionParameter::getClass. This is deprecated in PHP8 and thus
that usage has been replaced with an utility method that uses
the recommended replacement.
2020-10-16 11:31:26 +02:00
Rodrigo Primo
7599517e91
Merge pull request #27965 from woocommerce/fix/27874
...
switch to api package, bump utils package version
2020-10-15 15:05:43 -03:00
Ron Rennick
dd6d460fec
update e2e-environment readme
2020-10-15 14:53:21 -03:00
Ron Rennick
c3f934ad21
add e2e-environment package changelog
2020-10-15 14:14:22 -03:00
Ron Rennick
5815e5cf48
Merge pull request #27914 from woocommerce/fix/e2e-container-check
...
Only attempt to run E2E tests if testing host is ready
2020-10-15 13:44:55 -03:00
Ron Rennick
f0e6e1761c
Merge pull request #27913 from woocommerce/fix/27820
...
add test:e2e-debug command
2020-10-15 13:44:32 -03:00
Ron Rennick
0a7c0dc7fc
Merge pull request #27790 from woocommerce/fix/27787
...
Expose automattic/puppeteer-utils in e2e-environment
2020-10-15 09:52:52 -03:00
Néstor Soriano
e4a109f0d1
Merge pull request #27763 from woocommerce/fix/27445
...
Remove protection as we already diff and update only if needed.
2020-10-15 10:01:34 +02:00
Ron Rennick
f945a0e16c
switch to api package, bump utils package version
2020-10-14 15:13:08 -03:00
Ron Rennick
514e6cc308
document disabling puppeteer download
2020-10-14 13:59:37 -03:00
Vedanshu Jain
ae610d3f5f
Merge pull request #27492 from woocommerce/fix/api/229
...
Add User-friendly Attribute Names and Values to Order Line Items Metadata
2020-10-14 22:02:19 +05:30
vedanshujain
a332b399d3
Use variable instead of magic constants.
2020-10-14 18:50:44 +05:30
vedanshujain
c01f32a390
Use default value if formatted value is not available
2020-10-14 14:51:19 +05:30
vedanshujain
8e12de5d3c
Merge branch 'fix/api/229-unit-test' of https://github.com/shiki/woocommerce into fix/api/229
2020-10-14 13:53:03 +05:30
Julia Amosova
03078c5a9d
Implement `waitAndClick` in the setup e2e test.
2020-10-13 16:25:28 -04:00
Ron Rennick
13bcd43bfe
expose automattic/puppeteer-utils in e2e-environment
2020-10-13 16:16:32 -04:00
Ron Rennick
24713a45c3
restore shipping setup test
2020-10-13 16:15:07 -03:00
Shiki
1be78d1ebf
Use different terms to avoid clash with the similar V2 test
...
I suppose I could have deleted the attribute and term first but I think
this is better and shorter. Maybe.
2020-10-13 22:32:32 +05:30
Shiki
a9bf6b71ac
OrdersV2: Add test for line items meta_data
...
This currently fails because it's not implemented yet.
2020-10-13 22:32:32 +05:30
Shiki
871a9e0b8f
Add line items meta_data schema test for Orders V2 and V3
...
This currently fails because the expected meta_data properties are only
available in V3.
2020-10-13 22:32:32 +05:30
Shiki
c5fd3ed21c
WC_Tests_API_Orders: Add test data for site-level attributes
2020-10-13 22:32:31 +05:30
Shiki
62f1705690
WC_Tests_API_Orders: Rearrange order variable for clarity
2020-10-13 22:32:31 +05:30
Shiki
c16ec9bf54
WC_Tests_API_Orders: Rename first_meta_data to size_*
2020-10-13 22:32:31 +05:30
Shiki
a0d9b49e43
Add unit test for an Order's line item meta data.
2020-10-13 22:32:31 +05:30
Rodrigo Primo
5f5e739d7a
Update e2e test documentation to fix invalid example
...
This commit just updates the e2e test documentation to use a test file that exists in the section on how to run individual tests
2020-10-10 10:33:41 -03:00
Ron Rennick
903b86677c
add readme to core tests package
2020-10-09 10:31:45 -03:00
Ron Rennick
62acca06e1
don't run tests if testing host not ready
2020-10-09 05:14:57 -03:00
Ron Rennick
7f57906959
add test:e2e-debug command
2020-10-09 05:00:03 -03:00
Néstor Soriano
c15488d840
Merge pull request #27830 from woocommerce/php8/fix-round-function-with-non-numeric-argument
2020-10-09 08:01:44 +02:00
Christopher Allford
f9ef91adc1
Merge pull request #27836 from woocommerce/packages/api/add/repository-listing
...
@woocommerce/api: Added list() repository operation and classes for managing store settings
2020-10-08 13:20:12 -07:00
Christopher Allford
1d0cbc8187
Merge branch 'master' into packages/api/add/repository-listing
2020-10-08 11:48:22 -07:00
Ron Rennick
31001036c9
Merge branch 'master' into fix/25962
2020-10-08 15:30:25 -03:00
Néstor Soriano
e4b78cedbf
Merge pull request #27748 from woocommerce/remove-leftovers-from-improved-filtering-by-attribute-for-variations
...
Remove leftovers from the reverted improved filtering mechanism for variations
2020-10-08 15:45:09 +02:00
Néstor Soriano
ab529835fa
Merge pull request #27840 from woocommerce/php8/fix-required-parameters-after-optional
...
[PHP 8] Convert optional-before-required parameters into required parameters
2020-10-08 14:22:52 +02:00
Nestor Soriano
ac0641d02a
Fix a couple of incompatibilities with NumberUtils::round
...
- Passing a string that represents a number but has spaces (e.g. ' 1 ')
now works as expected (the number is properly interpreted)
- Passing the boolean true now returns 1, not 0
- Passing an object throws an error, instead of returning 0
2020-10-08 13:13:53 +02:00
Nestor Soriano
b71f876cba
Reintroduce the dependency injection related code.
...
After the League's Container package has been reintroduced, all the
code that implements the dependency injection mechanism in woocommerce
can be brought back as well.
2020-10-08 09:28:05 +02:00
Néstor Soriano
3e6861189e
Merge pull request #27848 from woocommerce/php8/remove-useless-test-assertion
...
[PHP 8] Remove a useless test assertion that fails in PHP 8
2020-10-08 09:06:39 +02:00
Ron Rennick
3a980a1241
merge current master
2020-10-07 03:17:38 -03:00
Ron Rennick
84fdfb6769
merge master
2020-10-07 03:05:04 -03:00
Julia Amosova
aac4db94b2
Merge pull request #27679 from woocommerce/packages/e2e/config-functions
...
add eslint & babel config functions to e2e-environment
2020-10-06 14:15:56 -04:00
Ron Rennick
df60bfb054
Merge pull request #27276 from woocommerce/fix/docker-ssh
...
Fix e2e docker:ssh command to work in any repo
2020-10-05 09:51:56 -03:00
Ron Rennick
610e787a86
package lock maintenance
2020-10-05 09:31:48 -03:00
Ron Rennick
5139c73029
allow running named test files that don't match test spec pattern
2020-10-05 09:16:27 -03:00
Christopher Allford
3558a9a025
Fixed a bug caused by differences in the URL when creating signatures on the client and server
2020-10-02 16:34:07 -07:00
Christopher Allford
6b5ff6d494
Fixed a bug that would cause Axios errors to be consumed by interceptors
2020-10-02 15:37:09 -07:00
Christopher Allford
b74adf215a
Adjusted the error mechanism to better follow the standard practice of rejecting HTTP errors
2020-10-02 14:10:24 -07:00
Nestor Soriano
ed33a607a7
Remove a useless test assertion that fails in PHP 8
...
The assertion is useless (the constant is already tested a few Lines
above), and it was failing in PHP 8 because 'auto' < 2 is evaluated
as false, while it's evaluated to true in PHP 7.
2020-10-02 15:27:26 +02:00
Nestor Soriano
7485b9165f
Convert optional-before-required arguments to required.
...
In PHP 8 required parameters after optional parameters in
function/method signatures trigger a deprecation notice. These type
of parameters are pointless since a value needs to always be
provided for them anyway, so they are actually de-facto required.
This commit converts all these not-so-optional parameters into
truly required parameters by removing their default values.
2020-10-02 09:45:09 +02:00
Christopher Allford
54b876fc75
Adjusted the typing of the ModelRepository and related interfaces to better distinguish between parent & child models
2020-10-01 18:06:34 -07:00
Christopher Allford
8f5ff436a2
Added support for flat parents to simplify calls with them
2020-10-01 17:48:37 -07:00
Christopher Allford
a01da2da93
Updated the lock files
2020-10-01 16:04:03 -07:00
Christopher Allford
e6efbdde34
Merge branch 'master' into packages/api/add/repository-listing
2020-10-01 15:58:48 -07:00
Christopher Allford
8ee89eb85d
Documentation fixes
2020-10-01 15:53:30 -07:00
Christopher Allford
cfa20570c1
Added appropriate HTTP errors to REST repository methods
2020-10-01 15:37:58 -07:00
Christopher Allford
f8574bed56
Added a utility service for updating settings
2020-10-01 15:23:46 -07:00
Christopher Allford
f0ad6e4fc2
Added aliases to make repository types easier to read
2020-10-01 15:00:27 -07:00
Christopher Allford
787040db4c
Adjusted the ModelRepository to make repository methods more type-safe
2020-10-01 14:31:55 -07:00
Christopher Allford
f2dda16c40
Updated lock files
2020-10-01 14:28:14 -07:00
Ron Rennick
c17b6b5ad0
Update expected industry count
2020-10-01 14:46:04 -03:00
Ron Rennick
4af90518da
lock file maintenance
2020-10-01 14:21:40 -03:00
Ron Rennick
8910357437
add missing test stubs
2020-10-01 10:25:22 -03:00
Nestor Soriano
52eed70f04
Add a 'NumberUtil' class with a 'round' method.
...
There's a number of places in the WooCommerce codebase where the
built-in function 'round' is executed passing a non-numeric value
(not a number and not a string that can be parsed as a number),
for example round(''). In PHP 7 this yields a value of 0, but in
PHP 8 this throws an error.
This commit adds a 'NumberUtil' class with a static 'round' method,
this method checks if the passed value is numeric and if so it just
executes the built-in function, otherwise it returns 0. And all the
calls to 'round' in the codebase are replaced with 'NumberUtil::round'.
2020-10-01 11:08:51 +02:00
Nestor Soriano
b1e81d02da
Fix code style/sniffer errors in a few files.
2020-10-01 11:08:51 +02:00
Christopher Allford
f6cbab8d07
Added missing static helpers for fetching repositories
2020-09-30 13:16:46 -07:00
Christopher Allford
fccf1fb66e
Added settings and group repositories with some basic functionality
2020-09-30 13:11:31 -07:00
Ron Rennick
be15429c30
restore ability to run individual tests
2020-09-30 17:05:02 -03:00
Ron Rennick
72219b2323
move merchant tests to package
2020-09-30 14:41:31 -03:00
Christopher Allford
4c2637c479
Added a `list` operation to the repository
2020-09-30 07:59:10 -07:00
Christopher Allford
f571324a09
Added better type-safety when distinguishing between resources that are children and those that are not
2020-09-29 18:40:50 -07:00
Ron Rennick
76f591251a
move front end tests to package
2020-09-29 17:00:34 -03:00
Ron Rennick
27e79f465f
split activation, onboarding, setup tests into separate files
2020-09-29 16:16:43 -03:00
Christopher Allford
8c5548d06e
Added @template JSDoc tag to API package for better IDE support
2020-09-29 12:00:09 -07:00
Ron Rennick
1abbe3f273
initial core test package files, move setup tests to package
2020-09-29 15:22:20 -03:00
Ron Rennick
fd60f7052a
Merge branch 'master' into fix/e2e-url-no-port
2020-09-28 16:15:22 -03:00
Christopher Allford
ef93f22321
Moved the product model for consistency with other model types
2020-09-25 14:08:19 -07:00
Christopher Allford
789773c65c
Fixed E2E test
2020-09-25 14:05:11 -07:00
Christopher Allford
44c7428358
Updated package lock files and fixed test error
2020-09-25 13:49:54 -07:00
Christopher Allford
760b0e4cdb
Merge branch 'master' into packages/factories-to-api-refactor
2020-09-25 13:19:36 -07:00
Christopher Allford
c09d91f6ce
Finished adding appropriate documentation to the API package
2020-09-25 11:11:17 -07:00
Ron Rennick
6b7d67e587
update onboarding flow for 4.6
2020-09-25 12:06:45 -03:00
vedanshujain
d51dd26816
Add unit tests.
2020-09-25 19:41:20 +05:30
Christopher Allford
ca0ea88e52
Updated the JSDoc and type-safety of repositories to better document the implemented operations
2020-09-24 14:22:38 -07:00
Ron Rennick
2ab59149ad
revert testing change to default.json
2020-09-24 12:27:35 -03:00
Julia Amosova
dcd0c46ab5
Merge pull request #27714 from woocommerce/fix/headless-flag-e2e-dev-mode
...
Add missing headless flag for running e2e tests in dev mode + README updates
2020-09-23 17:05:45 -04:00
Ron Rennick
bde41799af
merge master
2020-09-23 17:20:43 -03:00
Ron Rennick
a80dc37684
merge master
2020-09-23 16:26:17 -03:00
Ron Rennick
3fbdf46192
always remove the trailing slash from the base URL
2020-09-23 16:22:15 -03:00
Nestor Soriano
a94ea7f51f
Remove logic for storage of attribute terms for variations
...
A mechanism for improved filtering by attribute for variations was
introduced some time ago. This mechanism implied maintaining term
relationships for variations, where the terms were the attributes
that defined the variation.
The mechanism was reverted because it was complex and presented many
issues, but the code that created those term relationships was kept.
This pull request removes that code and the associated unit tests.
2020-09-22 16:31:06 +02:00
Christopher Allford
a7175c5ad4
Adjusted create method signature to better replicate TypeScript behavior
2020-09-21 13:44:45 -07:00
Christopher Allford
1674c05b66
Fixed the package.json files array to exclude development content
2020-09-21 13:33:57 -07:00
Christopher Allford
5297b27c79
Moved the factories from the @woocommerce/api package into the @woocommerce/e2e-utils package
2020-09-21 13:14:26 -07:00
Christopher Allford
b962c10cee
Updated the readme for the API package
2020-09-21 12:32:44 -07:00
Christopher Allford
fba5a46243
Integrated the API package into the utils package again to generate simple products
2020-09-21 11:22:43 -07:00
Christopher Allford
8e7ef263a2
Adjusted the package exports to be easier to consume
2020-09-21 11:21:35 -07:00
Julia Amosova
12d546b280
Add `PUPPETEER_SLOWMO` to global process.env to enable it.
2020-09-20 15:34:47 -04:00
Julia Amosova
c78051c7a5
Place back `scrollIntoView` to OBW e2e test.
2020-09-18 19:15:53 -04:00
Julia Amosova
ff8e5bbc8b
Remove `scrollIntoView` from OBW e2e test as it is not needed.
2020-09-18 18:33:21 -04:00
Christopher Allford
27d8892b28
Merge branch 'master' into packages/factories-to-api-refactor
2020-09-18 14:45:39 -07:00
Christopher Allford
bf70a3ea74
Updated lock files
2020-09-18 14:43:00 -07:00
Christopher Allford
d22ed6547e
Merge branch 'master' into package/e2e-environment/better-container-detection
2020-09-18 14:32:11 -07:00
Christopher Allford
866ab47dda
Adjusted the exports for clarity of use
2020-09-18 14:26:00 -07:00
Julia Amosova
6a93c8dd68
Added note to README on how to use `PUPPETEER_SLOWMO` variable.
2020-09-18 16:53:48 -04:00
Christopher Allford
b3b92e2d4d
Separated the construction of factories & repositories from the models for simplicity
2020-09-18 13:53:10 -07:00
Julia Amosova
30c904db68
Added `headless` & `slowMo` flags back to Puppeteer config.
2020-09-18 16:39:45 -04:00
Julia Amosova
38f14747fa
Update commands that need to be run to build e2e test env.
2020-09-18 16:05:36 -04:00
Julia Amosova
68c06683e7
Add note regarding re-initializing test container when `docker:down/up`.
2020-09-18 15:26:50 -04:00
Julia Amosova
24b987a409
Add link to `Test Variables` section when mentioning changing the port.
2020-09-18 15:22:25 -04:00
Julia Amosova
6a562f8dfa
Correct type: from `MariaDV` to `MariaDB` throughout e2e README.
2020-09-18 15:17:59 -04:00
Julia Amosova
085d7d884f
Add `Install NVM` section to README's Table of Contents.
2020-09-18 14:52:46 -04:00
Julia Amosova
2455a82f36
Add to README how to run tests using custom WP, PHP and MariaDV versions.
2020-09-18 14:48:26 -04:00
Julia Amosova
d66e7ef3b3
Update README with more accurate details on how to run e2e tests.
2020-09-18 14:30:54 -04:00
Julia Amosova
98edbef9a9
Add missing headless flag for running e2e tests in dev mode.
2020-09-18 13:43:44 -04:00
Ron Rennick
9915a5b142
merge master
2020-09-18 12:53:28 -03:00
Rodrigo Primo
197e8d274c
Merge pull request #27616 from woocommerce/fix/26960
...
Paypal gateway: protect code against a fatal error if WooCommerce is unable to communicate with PayPal
2020-09-18 09:34:57 -03:00
vedanshujain
140dafb704
Add unit tests for when PayPal API will return error
2020-09-18 17:12:33 +05:30
Claudio Sanches
29b8b0d60d
Merge pull request #27701 from woocommerce/fix/rest-api-package-tag
...
Fixed usage of package tag in REST API and templates
2020-09-17 18:45:14 -03:00
Christopher Allford
a9ee9806a4
Implemented the factory & repository for simple products
2020-09-17 13:31:39 -07:00
Claudio Sanches
7fae819928
Fixed package tag
2020-09-17 14:34:36 -03:00
Christopher Allford
6c230ca7b3
Centralized the CRUD actions into a single kind of repository that can be easily used in every adapter case
2020-09-17 09:43:43 -07:00
Claudio Sanches
3377c60c5e
Merge pull request #27433 from woocommerce/fix/remove-relative-include-paths
...
Change relative include paths to absolute include paths
2020-09-17 13:15:40 -03:00
Claudio Sanches
70c7adfeb7
Fixed usage of package tag in REST API and templates
2020-09-17 11:56:08 -03:00
Claudio Sanches
ed1a59b39b
Merge pull request #27416 from woocommerce/fix/27415
...
Fixed country list sorting
2020-09-17 10:35:43 -03:00
Christopher Allford
3a7c96b7cd
Revised the base tsconfig to match Gutenberg more closely
2020-09-16 15:14:53 -07:00
Christopher Allford
011974ec09
Merge branch 'master' into packages/factories-to-api-refactor
2020-09-16 11:51:49 -07:00
Christopher Allford
f5e130c190
Merge pull request #27667 from woocommerce/fix/standardize-nvm-usage
...
Standardize usage of NVM
2020-09-16 11:40:48 -07:00
Christopher Allford
38afb8c2ff
Merge branch 'master' into packages/factories-to-api-refactor
2020-09-15 14:49:22 -07:00
Ron Rennick
87ea5dbffc
add eslint, babel config functions
2020-09-15 14:08:19 -03:00
Ron Rennick
7c509d8ddb
use tabs for indentation
2020-09-15 10:10:59 -03:00
Ron Rennick
0bf505ab12
Merge pull request #27645 from woocommerce/update/e2e-utils-for-package
...
prep e2e-utils package for publish
2020-09-14 14:40:19 -03:00
Christopher Allford
a77a1cc77c
Refreshed all lock files and removed "woocommerce" dependency from "e2e-environment"
2020-09-14 10:00:32 -07:00
Ron Rennick
be8ba23801
merge master
2020-09-11 15:32:10 -03:00
Ron Rennick
cd80e67717
merge master
2020-09-11 14:35:27 -03:00
Christopher Allford
2e7f1056e0
Replaced the environment dependency version resolution to use the Docker HTTP API
...
Since it's possible that the latest git tag isn't a Docker page we should get the latest version directly from Docker instead. This commit adds support for the `/v2/repositories/library/<image>/tags` endpoint and figures out the latest version from the response.
2020-09-10 14:26:44 -07:00
Christopher Allford
07bbf56ace
Removed unnecessary `woocommerce` dependency from E2E package
2020-09-10 13:05:31 -07:00
Ron Rennick
238fe43a61
prep e2e-utils package for publish
2020-09-10 16:10:48 -03:00
Claudio Sanches
b5d8d94bc8
Use reference in wc_asort_by_locale
2020-09-10 16:02:39 -03:00
Ron Rennick
0d3889a360
Merge pull request #27113 from woocommerce/add/e2e-feedback-blockers
...
Incorporate blocking issues feedback on initial e2e environment package
2020-09-10 15:56:09 -03:00
Ron Rennick
1c07d5ec5a
restore looking up tags from git, add npm install to travis e2e script
2020-09-10 14:54:35 -03:00
jonathansadowski
2bcdbacc98
Merge pull request #27625 from woocommerce/revert-improved-filtering-for-variations
...
Revert improved filtering for variations
2020-09-10 12:42:15 -05:00
Ron Rennick
bff1e799f4
use better test for creating ready page
2020-09-10 13:23:18 -03:00
Christopher Allford
14c46fa4c2
Merge branch 'master' into add/e2e-feedback-blockers
2020-09-09 14:47:51 -07:00
Christopher Allford
d0e6110e93
Fixed a failing E2E test
2020-09-09 14:47:44 -07:00
Christopher Allford
aabc8ccd6b
Updated all of the package-lock files using Node v10
2020-09-09 14:47:35 -07:00
Ron Rennick
25cbfd2452
run grunt directly in travis e2e
2020-09-09 17:00:06 -03:00
Christopher Allford
ae697f9fe2
Prevented zero from being considered empty when validating posted variation attributes
2020-09-09 11:29:31 -07:00
Christopher Allford
63e4dcf4a2
Created a transformer class to use in model repositories
...
Since models need to support both read & write transformations we can make dealing with this a bit easier in its own class now.
2020-09-09 10:00:30 -07:00
Nestor Soriano
70a1cb2f1f
Revert improved filtering for variations.
...
This commit reverts the functionality introduced in PR #26260
(later refined by #27175 , #27190 , #27508 ) in which filtering by
attribute using the layered nav widget was improved to handle the
cases of variations out of stock. The revert is a response to the
numerous problems reported by users in Woo 4.4 and 4.5
Not all the code has been reverted, only the code that resulted in
visible functionality changes. Thus, the code that generates
term relationships for variations is still in place to keep database
consistency and to keep the reverting changes to the minimum needed.
2020-09-09 17:36:26 +02:00
jonathansadowski
d00083f1ec
Merge pull request #27628 from woocommerce/fix/27624
...
Check for state and postcode fields only if required
2020-09-09 09:41:57 -05:00
vedanshujain
6a2ea0e27a
Add unit test for show_shipping for different countries.
2020-09-09 19:53:21 +05:30
Ron Rennick
21e099d48f
merge master
2020-09-09 11:17:20 -03:00
Claudio Sanches
e0f08cc65a
Use global phpcs
2020-09-08 16:53:13 -03:00
Claudio Sanches
f748a71a8e
Install globally
2020-09-08 15:56:06 -03:00
Claudio Sanches
aa57d2f676
Update sniffs installation
2020-09-08 15:11:42 -03:00
jonathansadowski
168698cd91
Merge pull request #27589 from woocommerce/enhance-query-for-filtering-attributes-with-any-value
...
Enhance the query for "Any" variations in filter by attribute widget
2020-09-08 11:58:54 -05:00
Christopher Allford
39c5bc6b74
Refactored the factory to use a repository instead of an adapter so that we can expose more API functionality
2020-09-07 16:00:27 -07:00
Christopher Allford
a875ecb083
Refactored the HTTP layer to be more API-agnostic
...
Since we're going to be adding more services and CRUD actions it makes sense for our HTTP services to be less tied to the specific REST API implementation.
2020-09-04 11:27:34 -07:00
Julia Amosova
e224cd4b1b
Update how disablement of the extensions download is handled in OBW test
2020-09-04 11:47:02 -04:00
Nestor Soriano
43642f7835
Enhance the query for "Any" variations in filter by attribute widget.
...
The new query fixes a bug where variations were being counted twice:
if a product was included in both the queries then it would be counted
differently and added; e.g. when a product had two variations,
one with "Any" attribute and other with a attribute that has a value.
The new query also optimizes performance, so that filter conditions
can be improved and better indexes can be used.
2020-09-04 11:29:50 +02:00
Julia Amosova
4ca4f37969
Update recommended business features checkbox selector in OBW test
2020-09-03 16:23:19 -04:00
Christopher Allford
c75f0f8886
Renamed the `@woocommerce/factories` package to `@woocommerce/api`
...
With the plan now to add more CRUD actions the scope of the package has transformed into a more general API package than one just for factories.
2020-09-03 12:28:17 -07:00
Julia Amosova
552545c0ac
Update number of industries in the loop from 10 to 9
2020-09-03 13:17:47 -04:00
jonathansadowski
ecb25d7dc8
Merge pull request #27572 from woocommerce/update/bump-wc-admin-to-1.5.0-rc.4
...
Bump WooCommerce Admin to 1.5.0-rc.4; WooCommerce to 4.5.0-rc.3
2020-09-02 19:21:52 -05:00
Christopher Allford
c898e1de03
Fixed failing E2E test
2020-09-02 16:14:25 -07:00
Christopher Allford
f5771ebd0a
Fixed failing E2E test
2020-09-02 16:13:20 -07:00
Christopher Allford
b9d314e1ae
Fixed another E2E test
2020-09-02 15:47:15 -07:00
Christopher Allford
dde64b964f
Updated lock files & fixed failing E2E test
2020-09-02 14:50:08 -07:00
Christopher Allford
d3162b2f1d
Updated package-lock.json files
2020-09-02 14:39:49 -07:00
Christopher Allford
aee44c2935
Merge remote-tracking branch 'origin/master' into add/e2e-feedback-blockers
2020-09-02 12:47:40 -07:00
Christopher Allford
16cf8c81be
Revised the default environment variables to pull the version from the latest docker image
2020-09-02 12:47:27 -07:00
jonathansadowski
53c22ba4e4
Merge pull request #27508 from woocommerce/fix/27419
...
Fix filter by attribute widget now working for "Any..." attributes
2020-09-02 13:32:54 -05:00
Shiki
d6600d8338
Version3/orders.php: Re-add assertion for `meta_data`
2020-09-01 14:29:38 -06:00
Shiki
5651befdd9
Version3/orders.php: Remove assertion for `meta_data`
...
The new meta_data output will include keys like `display_key` and
`display_value`. The assertion will be re-added in a later commit.
2020-09-01 14:22:38 -06:00
Shiki
64bd1e0fd5
Fix formatting errors in orders.php
2020-09-01 14:21:14 -06:00
Nestor Soriano
07b62dabbd
Improve the query to retrieve "Any..."-attributed variations in filtering widget
...
The new query doesn't need empty attribute entries in the meta table,
therefore the code that generates them and the migration to backfill
the missing existing ones have been removed.
2020-09-01 16:47:41 +02:00
Nestor Soriano
3a583feab1
Change filter by attributes widget to count products, not variations.
...
Right now the filter by attributes widget counts available variations
(for variation products). This is confusing since the counter shows
numbers that are higher than the actual count of products displayed.
This commit changes the query used by the widget so that instead
of counting variations it returns the parent product ids, and then
counts the distinct values. This also covers the case of products
where some of the variations have concrete values and some have
"Any..." values.
2020-08-31 12:22:33 +02:00
Ron Rennick
0b85ee58f8
update package-lock.json
2020-08-28 11:06:25 -03:00
Ron Rennick
17ee223e71
update package-lock.json
2020-08-28 11:03:28 -03:00
Ron Rennick
8fe3bcb90e
rebase to current master
2020-08-28 10:59:43 -03:00
Claudio Sanches
085b4b53fa
Merge pull request #27487 from woocommerce/update/choice-of-words
...
Improve choice of words
2020-08-27 19:30:54 -03:00
Nestor Soriano
1113201f8b
Update meta 'attribute_' values when variation attributes are added or removed.
...
When a new variation attribute is added, the corresponding 'attribute_'
meta entries are added for all variations with an empty value;
and when an existing variation attribute is removed, the existing
'attribute_' meta entries are deleted for all variations.
This is necessary for the filter by attribute widget to work properly
when variations exist with a value of "Any..." for attributes.
2020-08-27 16:10:41 +02:00
Nestor Soriano
a75da34a45
Fix filter by attribute widget now working for "Any..." attributes
...
When a variation product has an attribute with a value of "Any...",
and there's a filter by attribute widget for that attribute, then
that product won't be included in the counts displayed in the widget
(and if the count ends up being zero, the attribute won't be shown
in the widget).
This happens before since Woo 4.4, this widget works by looking at
entries in the term relationships table for varitions too
(used to do so for simple products and for "main" variable products
only), see PR #26260 ; but there are no such entries for
"Any..." attributes.
This commit fixes that by extending the SQL query used by the widget
to look for variations that have empty attribute values in the meta
table too.
2020-08-27 10:59:15 +02:00
Claudio Sanches
c4ccc38780
Fixed use __DIR__ for relative paths
2020-08-26 18:46:44 -03:00
Shiki
ecb2936f9e
Use different terms to avoid clash with the similar V2 test
...
I suppose I could have deleted the attribute and term first but I think
this is better and shorter. Maybe.
2020-08-26 23:51:36 +05:30
Shiki
face3fe27e
OrdersV2: Add test for line items meta_data
...
This currently fails because it's not implemented yet.
2020-08-26 23:51:36 +05:30
Shiki
ad00eb3a98
Add line items meta_data schema test for Orders V2 and V3
...
This currently fails because the expected meta_data properties are only
available in V3.
2020-08-26 23:51:36 +05:30
Shiki
2a01aa968f
WC_Tests_API_Orders: Add test data for site-level attributes
2020-08-26 23:51:36 +05:30
Shiki
dc2a4d1ccc
WC_Tests_API_Orders: Rearrange order variable for clarity
2020-08-26 23:51:36 +05:30
Shiki
00a5c3101e
WC_Tests_API_Orders: Rename first_meta_data to size_*
2020-08-26 23:51:36 +05:30
Shiki
d681a8c7a4
Add unit test for an Order's line item meta data.
2020-08-26 23:51:36 +05:30
Claudio Sanches
5240682f38
Improve choice of words
2020-08-25 18:03:03 -03:00
Claudio Sanches
a133e56ebd
Fixed unit tests
2020-08-25 16:13:49 -03:00
Ron Rennick
81dae70033
phpcs fixes
2020-08-25 15:41:31 -03:00
Ron Rennick
de79f1a3cd
update unit tests for included Paypal gate name change
2020-08-25 15:36:50 -03:00
Ron Rennick
074b2b86c6
update package-lock.json
2020-08-21 13:39:33 -03:00
Ron Rennick
7a14368982
add small tweaks/checks for edge cases
2020-08-21 13:25:30 -03:00
Tam Mullen
b41bd5139d
Updating e2e test for OBW changes
2020-08-21 16:03:02 +01:00
Ron Rennick
51afe3207a
Merge pull request #27023 from HikeMike/add/hidden-form-field
...
"Hidden" field type added to woocommerce_form_field() #26468
2020-08-20 11:48:26 -03:00
Claudio Sanches
47aaac8600
Introduced wc_asort_by_locale() function
2020-08-19 20:22:18 -03:00
Claudio Sanches
b5221ab479
Added unit tests for changes in wc_ascii_uasort_comparison
2020-08-19 19:00:18 -03:00
Claudio Sanches
98d5f52de2
Merge branch 'master' into add/woorelease-support
2020-08-19 12:10:15 -03:00
Ron Rennick
dfdf4e9d18
update e2e config parsing to support no port
2020-08-19 09:57:14 -03:00
Christopher Allford
358db5dc3e
Removed the internals of the Container pending package conflict resolution
...
Since reverting the PR at this point would be a mess I've gone ahead and removed the internals of the container. We should aim to keep the class since it's now part of our public API but it won't work as expected anymore. This is fine for now since we don't actually have anything in it!
2020-08-18 20:39:48 -07:00
Claudio Sanches
9773675b8d
Merge branch 'master' into add/woorelease-support
2020-08-18 17:59:47 -03:00
Claudio Sanches
e102ec3d83
Merge branch 'master' into fix/25133
2020-08-17 14:59:49 -03:00
Néstor Soriano
f1ed7005f9
Merge pull request #26232 from woocommerce/update/e2e-test-utils
...
Update/e2e test utils
2020-08-17 15:26:13 +02:00
Claudio Sanches
bb0c4406de
Merge pull request #27314 from woocommerce/add/unit-tests-27108
...
Added unit tests for #27244
2020-08-14 15:32:02 -03:00
Ron Rennick
45391c4b18
update unit test for account page being automatically created
2020-08-14 10:36:16 -03:00
Ron Rennick
f0ad8a01be
merge current master
2020-08-13 14:33:07 -03:00
Vedanshu Jain
a887cd7369
Merge pull request #27318 from woocommerce/fix/27282
...
Change data-type from mixed to composite and date-time to string on the fly for REST API
2020-08-13 21:25:11 +05:30
vedanshujain
7fa6510c1a
Add a explicit test for null as well
2020-08-13 16:52:16 +05:30
vedanshujain
dd9b9cfae2
Add test for update in date-time field
2020-08-13 16:32:00 +05:30
vedanshujain
4294e06f7a
Add test for variation v2 controller for complex meta object
2020-08-13 15:46:31 +05:30
vedanshujain
9f680aa120
Add test for null meta value as well
2020-08-13 14:17:28 +05:30
vedanshujain
826fdde721
Add unit tests for checking that updating complex meta is possible
2020-08-13 13:27:00 +05:30
Néstor Soriano
4c636b1d5c
Merge pull request #27303 from woocommerce/fix/travis-coding-standards-test
...
Fix coding standards test on Travis
2020-08-13 09:19:13 +02:00
Claudio Sanches
1839feae91
Added unit tests for #27244
2020-08-12 18:50:25 -03:00
Christopher Allford
7340c9af44
Merge pull request #27171 from woocommerce/fix/25543
...
Added the parent's SKU to product searches for variations
2020-08-12 12:58:00 -07:00
Claudio Sanches
1699b34295
Use npm run build:core
2020-08-12 16:53:06 -03:00
Christopher Allford
7071c6dc0c
Merge pull request #27228 from woocommerce/feature/container-injection-change
...
Dependency Injection should use method injection instead of constructor injection
2020-08-12 12:41:48 -07:00
Claudio Sanches
521ad8c3ff
Update all dependencies of woocommerce-sniffs
2020-08-11 20:42:42 -03:00
Claudio Sanches
7fdf209713
Check if PHPCS is installed before trying to install a new copy
2020-08-11 20:08:28 -03:00
Claudio Sanches
29bc98816e
Merge pull request #27143 from woocommerce/fix/26876
...
Fix "Hide shipping costs until an address is entered"
2020-08-11 20:06:17 -03:00
Ron Rennick
4ba2e0267f
remove unused local test-e2e.json
2020-08-11 09:53:34 -03:00
Tam Mullen
9ad9ff2df8
Fixing import path
2020-08-11 12:26:53 +01:00
Tam Mullen
c8365213c3
Fixing import path.
2020-08-11 00:34:57 +01:00
Tam Mullen
ed525087ac
Addressing comments.
2020-08-10 21:27:20 +01:00
Tam Mullen
b2262f1cf7
Updating exports for completeOnboardingWizard function.
2020-08-10 21:26:11 +01:00
Tam Mullen
2bc918d353
Updating e2e-utils formatting.
2020-08-10 21:26:10 +01:00
Tam Mullen
cdaefa332e
Updating e2e-utils formatting.
2020-08-10 21:26:10 +01:00
Tam Mullen
4544190462
Updating e2e-utils dependencies.
2020-08-10 21:26:10 +01:00
Tam Mullen
ead4b93a7d
Adding e2e-utils README
2020-08-10 21:26:10 +01:00
Tam Mullen
da1916c663
Updating product test dependencies
2020-08-10 21:26:10 +01:00
Tam Mullen
43c55e2c6a
Converting e2e-utils to package.
2020-08-10 21:26:10 +01:00
Ron Rennick
0b0595ab4c
Merge pull request #27048 from vallter2/postcode-bih
...
Add postcode validation for Bosnia and Herzegovina
2020-08-10 16:24:06 -03:00
Ron Rennick
c14ce54752
fix e2e docker:ssh command to work in any repo
2020-08-10 14:54:10 -03:00
Christopher Allford
116e11565a
Merge pull request #27262 from woocommerce/fix/unit-tests-coding-standards
...
Fixed packages required to run code sniffer on unit tests
2020-08-10 06:57:05 -07:00
Christopher Allford
12397aec0e
Added `_with` suffix to `StringUtil` methods for clarity
2020-08-07 16:45:35 -07:00
Christopher Allford
13a3b80cb6
Removed classes accidentally added back by merge from master
2020-08-07 16:45:09 -07:00
Christopher Allford
eb65252ba8
Merge branch 'master' into feature/container-injection-change
2020-08-07 14:35:44 -07:00
Christopher Allford
081f0d9133
Settled on an injection method of `init`
...
1. Since our code style dictates that these be `final` methods, we shouldn't be concerned about overlap.
2. There is precedent for `init` methods as requirements before using class instances.
2020-08-07 14:28:29 -07:00
Claudio Sanches
02cf0dfaed
Merge pull request #27239 from woocommerce/fix/package-tag
...
Fix usage of "package" tag in file headers
2020-08-07 13:37:24 -03:00
Claudio Sanches
17f9883f00
Changed | to \
2020-08-07 13:36:41 -03:00
Claudio Sanches
48732ee0dd
Fixed package tag
2020-08-07 13:35:15 -03:00
Claudio Sanches
3fd42a0fd5
Fixed packages required to run code sniffer on unit tests
2020-08-07 13:28:41 -03:00
Ron Rennick
6aa52c8499
remove duplicate readme text
2020-08-07 13:04:36 -03:00
Ron Rennick
db76c8ac2d
merge package config with factories changes
2020-08-07 10:53:51 -03:00
Néstor Soriano
76cf1e4e93
Merge pull request #27140 from woocommerce/fix/23790
...
Always sanitize coupon code to prevent inconsistent between admins and shop owners
2020-08-07 12:42:02 +02:00
Néstor Soriano
a13a0d2187
Merge pull request #27179 from woocommerce/fix/26741
...
Release coupon holds when status it updated to cancelled regardless of recorded coupons
2020-08-07 11:27:45 +02:00
Christopher Allford
154c812fc0
Renamed the `StringUtility` to `StringUtil` to make it easier to work with
2020-08-06 12:35:51 -07:00
Claudio Sanches
9eae43c0d4
Merge pull request #27240 from woocommerce/dependabot/npm_and_yarn/tests/e2e/factories/lodash-4.17.19
...
Bump lodash from 4.17.15 to 4.17.19 in /tests/e2e/factories
2020-08-06 15:50:26 -03:00
vedanshujain
2f76e52fa7
Skip test for < 5.3 as feature is not supported.
2020-08-06 14:34:02 +05:30
vedanshujain
55a9687e6d
Make api included structure more linear.
2020-08-06 14:34:02 +05:30
vedanshujain
cfe357cfb2
Fix UT to add predefined values to run tests in isolation.
2020-08-06 14:34:02 +05:30
vedanshujain
222852dea6
Merge branch 'master' of https://github.com/woocommerce/woocommerce
2020-08-06 14:06:29 +05:30
Christopher Allford
39376abfd2
Added a requirement that `container_init` methods be marked `final` when registering using reflection
2020-08-05 22:34:00 -07:00
Christopher Allford
ff6e30f1c1
Renamed `set_internal_dependencies` to `container_init`
2020-08-05 22:20:13 -07:00
Christopher Allford
cbbfed4989
Replaced the rest of the constructor injection references
2020-08-05 21:28:06 -07:00
dependabot[bot]
089df498d3
Bump lodash from 4.17.15 to 4.17.19 in /tests/e2e/factories
...
Bumps [lodash](https://github.com/lodash/lodash ) from 4.17.15 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases )
- [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-08-05 23:04:18 +00:00
Christopher Allford
8e8698a3f6
Fixed test that used PHPUnit function from newer version
2020-08-05 15:43:08 -07:00
Christopher Allford
678705cdd4
Merge branch 'master' into package/e2e-factories/product
2020-08-05 14:00:05 -07:00
Ron Rennick
0ca4ce27c5
update e2e readmes
2020-08-05 16:58:38 -03:00
Ron Rennick
7f04d800e9
keep browser reset at end of setup
2020-08-05 15:01:43 -03:00
Claudio Sanches
3632714885
Removed package tag from src
2020-08-05 14:23:50 -03:00
Claudio Sanches
a50552af75
Use only WooCommerce as package name
2020-08-05 14:11:20 -03:00
Claudio Sanches
d48f1d4e2e
Fixed package tag usage
2020-08-05 13:36:24 -03:00
Ron Rennick
7799c1bcf0
merge master
2020-08-05 10:33:16 -03:00
Tam Mullen
5a410c02a6
Fix e2e OBW test to not untick physical products in product type list
2020-08-05 12:49:42 +01:00
Christopher Allford
d178c7ff01
Replaced constructor injection with method injection
...
Since we need to maintain backwards compatibility for class constructors we should settle on using method injection instead of constructor injection. I've replaced the `Definition` class we're using with one that doesn't support constructor arguments and added a check for auto_arg addition. Note that we don't check for method existence in the extended container. This is because reflection is unnecessarily expensive and we should avoid it if at all possible.
2020-08-04 20:37:28 -07:00
Ron Rennick
52d67cead1
move trash posts/products from sequencer to local config
2020-08-04 19:55:13 -03:00
Ron Rennick
14c9154fcb
use consistent MySQL configuration values
2020-08-04 16:17:00 -03:00
vedanshujain
1ada7d8b26
Merge branch 'master' of https://github.com/woocommerce/woocommerce
2020-08-04 18:22:41 +05:30
Nestor Soriano
200599f8e0
Add unit tests for the type of the value returned by 'get_available_variations'
2020-08-03 16:30:54 +02:00
Nestor Soriano
71fccd6a07
Fix: pagination controls not displaying in products list.
...
This bug was introduced in #26260 . The sequence is:
1. WC_Query::adjust_posts_count runs, to handle found_posts filter,
this indirectly executes wc_setup_loop.
2. At this point $GLOBALS['wp_query']->max_num_pages hasn't been set
yet, and has a value of 0. Thus the loop variable total_pages
is set to 0.
3. Later wc_setup_loop runs again and this time
$GLOBALS['wp_query']->max_num_pages is already set, but since
the loop variable total_pages already exists, it keeps its
value of 0.
4. The pagination controls never show if total_pages is less than 2.
The fix consists of hooking into the_posts to set the value of
total_pages again, at that point $GLOBALS['wp_query']->max_num_pages
is already set.
2020-07-31 16:40:25 +02:00
Claudio Sanches
825d57dd41
Merge branch 'master' into fix/23790
2020-07-30 17:33:50 -03:00
Claudio Sanches
48974f29f1
Fixed unit tests for WC_Notes_Run_Db_Update
2020-07-30 17:00:11 -03:00
Claudio Sanches
1cd84d6446
Merge branch 'master' into fix/23790
2020-07-30 16:46:01 -03:00
Claudio Sanches
608fc8620d
Merge pull request #27172 from woocommerce/fix/27168
...
Let user stay in the same page after clicking to update WooCommerce
2020-07-30 15:48:27 -03:00
Jonathan Sadowski
163e10253a
Release coupon holds when status it updated to cancelled regardless of recorded coupons
2020-07-30 10:35:23 -05:00
Néstor Soriano
e44154bf6e
Update tests/legacy/unit-tests/util/class-wc-tests-wc-query.php
...
Fix small coding standards issue.
Co-authored-by: Claudio Sanches <contato@claudiosanches.com>
2020-07-30 16:17:05 +02:00
vedanshujain
3a63d75e0f
Merge branch 'master' of https://github.com/woocommerce/woocommerce
2020-07-30 17:55:11 +05:30
Nestor Soriano
86c88f1750
Fix: incorrect adjustment of post count in WC_Query.
...
PR #26260 introduced a handler for 'found_posts' filter in WC_Query
class in order to adjust the count depending on the visibility
of variation products. However the handler incorrectly assumed
that the filter was triggered only when listing products, when
actually it's also triggered for any post type e.g. pages.
In these cases the post count was set to zero, which caused bugs.
Now the handler starts with the originally supplied posts count,
and only decrements it when a post is a product AND is not visible.
2020-07-30 09:32:28 +02:00
Claudio Sanches
3c1132e274
Added unit tests for wc_get_current_admin_url()
2020-07-29 21:02:52 -03:00
Christopher Allford
78bff3b2da
Added the parent's SKU to product searches for variations
...
Since the parent's SKU is used when the variation does not have one, we should fall back when searching for consistency.
2020-07-29 16:53:36 -07:00
Ron Rennick
ba942aa32f
expose getAppRoot, getTestConfig in package
2020-07-29 20:03:29 -03:00