Commit Graph

622 Commits

Author SHA1 Message Date
renovate[bot] dfc7d8ae1b Update dependency core-js to v2.6.1 (https://github.com/woocommerce/woocommerce-admin/pull/1128) 2018-12-21 20:03:41 -06:00
Justin Shreve 579113910d Add remaining filters to the downloads report (https://github.com/woocommerce/woocommerce-admin/pull/1141)
* Add order number, username, and IP address filters to the downloads report.

* Adds tests
2018-12-21 16:40:41 -08:00
Robert Elliott ebd857cefa Add/chart dashboard block (https://github.com/woocommerce/woocommerce-admin/pull/1002)
* added new block and dashboard charts

section title and filters... lots of duplicate keys

toggle chart types in block heading

* Updates per feedback.

* Add some documentaiton about new interactive prop on chart/legend

* Revert a few files that only had whitespace changes.
2018-12-21 16:24:26 -08:00
Joshua T Flowers 56577101c4 Add customer numeric filters (https://github.com/woocommerce/woocommerce-admin/pull/1116)
* Add customer numeric filters

* Add between params to customers controller

* Escape strings for translation and change inputs to currency

* Add Currency shorthand filter
2018-12-21 12:07:54 +08:00
Paul Sealock c76ceb2591 DatePicker: cleanup example, propTypes 2018-12-21 15:19:10 +13:00
Paul Sealock 524bb0c96f DateRangeFilterPicker 2018-12-21 11:58:01 +13:00
Albert Juhé Lluveras 1cb7378f76 Fix Tag misalignment inside Search in Firefox (https://github.com/woocommerce/woocommerce-admin/pull/1132) 2018-12-20 10:06:52 +01:00
Albert Juhé Lluveras 776e8d31fe Merge pull request woocommerce/woocommerce-admin#1085 from woocommerce/add/name-filter-autocompleter
Customers report: Name Advanced Filter
2018-12-19 10:39:22 +01:00
Timmy Crawford eab3592d67 Update npm versions and build script (https://github.com/woocommerce/woocommerce-admin/pull/1120)
* Use publish from-package.

* chore(release): publish

 - @woocommerce/components@1.3.0
 - @woocommerce/csv-export@1.0.1
 - @woocommerce/date@1.0.3
2018-12-18 17:25:26 -08:00
Jeff Stieler a96272a5fe Merge pull request woocommerce/woocommerce-admin#1119 from woocommerce/fix/1115-number-filter-uncontrolled-warning
Fix “uncontrolled input” warning in NumberFilter component.
2018-12-18 16:34:39 -07:00
Jeff Stieler 8ee2267209 Update @woocommerce/date package changelog and version number. 2018-12-18 15:46:48 -07:00
Jeff Stieler 7bc46d2c8c Fix loadLocaleData() tests, remove superfluous moment-js tests. 2018-12-18 15:46:47 -07:00
Jeff Stieler 3285ac4980 Include Date component required settings in app-wide settings object instead of using experimental retrieval from @wordpress/date. 2018-12-18 15:46:46 -07:00
Jeff Stieler 4d37bdc67c @wordpress/date getSettings() is deprecated, use __experimentalGetSettings() instead. 2018-12-18 15:45:41 -07:00
Jeff Stieler 92c96b834e Fix “uncontrolled input” warning in NumberFilter component. 2018-12-18 09:01:30 -07:00
Albert Juhé Lluveras 3a1890c22c Remove unnecessary variable assignment 2018-12-18 15:06:06 +01:00
Albert Juhé Lluveras c4290f757e Merge branch 'master' into add/name-filter-autocompleter 2018-12-18 13:52:48 +01:00
Albert Juhé Lluveras 3c876fedf1 Filter missing parts of the name before displaying it 2018-12-18 13:46:24 +01:00
Albert Juhé Lluveras a836d1a89b Add customer username filter to Customers page 2018-12-18 12:11:45 +01:00
Justin Shreve e42ad6956b Add customer email filter (https://github.com/woocommerce/woocommerce-admin/pull/1092)
* Add customer email filter

* Handle PR feedback: Fix up if statement and add extra info to validation comment
2018-12-17 11:20:11 -05:00
Albert Juhé Lluveras c341137a1b Store shouldRenderTags in a variable 2018-12-17 12:21:17 +01:00
Albert Juhé Lluveras d8bf42fc4d Typo 2018-12-17 12:20:23 +01:00
Jeff Stieler 08c31151b4 Merge pull request woocommerce/woocommerce-admin#1089 from woocommerce/add/1028-advanced-numerical-value-filter
Add Advanced Numerical Value Filter
2018-12-14 18:02:16 -07:00
Jeff Stieler 6eadf9c875 NumberFilter: rename “more than” and “less than” to represent a non-positional input range for “between” rules, simplify rule change logic. 2018-12-14 16:53:13 -07:00
Timmy Crawford 88b81beac0 Updating changelogs for npm release. (https://github.com/woocommerce/woocommerce-admin/pull/1088)
* Updating changelogs for npm release.

* Adding in a few more changelog items.
2018-12-14 10:44:24 -08:00
Jeff Stieler fea292125d Fix import path for formatCurrency(). 2018-12-14 11:26:11 -07:00
Albert Juhé Lluveras 3e9f141eca Fixes 2018-12-14 18:06:02 +01:00
Jeff Stieler 93b05bba94 Square off the corners of TextControlWithAffixes. 2018-12-14 09:59:37 -07:00
Jeff Stieler 2b8526bbfb Stope NumberFilter inputs from overflowing their container in “between” mode. 2018-12-14 09:59:23 -07:00
Albert Juhé Lluveras d972ebf672 Only update search filters based on query if the query changed 2018-12-14 17:38:31 +01:00
Albert Juhé Lluveras 302ff934d1 Make sure 'filter:advanced' is set in the URL when setting a search filter 2018-12-14 17:30:07 +01:00
Albert Juhé Lluveras 07227271fd Avoid duplicated ids when searching customers from the table search box 2018-12-14 17:19:30 +01:00
Albert Juhé Lluveras bc5073ecd4 Make sure filters are updated when using the table search box 2018-12-14 17:14:24 +01:00
Justin Shreve 43055d25a5 Add a country filter to the customers report (https://github.com/woocommerce/woocommerce-admin/pull/1080)
* Add an advanced country filter to the customers report

* Handle PR feedback: Fix PropType warnings, move filter/label logic to config getLabels() function, fix typo.

* Add flag thumbnail to the country filter

* Update README and CHANGELOG
2018-12-14 10:13:34 -05:00
Albert Juhé Lluveras 578e01b12f Hide selected items in filters from table search box autocompleter 2018-12-14 14:31:57 +01:00
Albert Juhé Lluveras bb16ba07c8 Use search box for searches instead of comparisons in Customers table 2018-12-14 14:31:41 +01:00
Albert Juhé Lluveras ce080f4fe0 Use WC regular endpoint instead of reports endpoint to load customers autocompleter suggestions 2018-12-14 11:27:59 +01:00
Jeff Stieler aef873b386 Add examples of NumberFilter to the docs. 2018-12-13 17:30:29 -07:00
Jeff Stieler 89b4ab4d10 Format currency values for NumberFilter legend text. 2018-12-13 17:30:29 -07:00
Jeff Stieler 8e8e6d6d97 Use store’s currency symbol position setting to select prefix/suffix when rendering an advanced number filter input. 2018-12-13 17:30:29 -07:00
Jeff Stieler de53c50514 Handle NumberFilter value when changing rule type. 2018-12-13 17:30:29 -07:00
Jeff Stieler 38bb06d39b Render “currency” input type for NumberFilter component. 2018-12-13 17:30:29 -07:00
Jeff Stieler cb09c195c8 Render a currency-prefixed input for advanced number filters of type “currency”. 2018-12-13 17:30:27 -07:00
Jeff Stieler e620f8ef92 Generate screen reader text for number filter value . 2018-12-13 17:30:14 -07:00
Jeff Stieler 39a2da70b6 Display advanced number filters inline. 2018-12-13 17:30:01 -07:00
Jeff Stieler 477c83bac2 Use external config for NumberFilter rules. Fixes filter query parsing. 2018-12-13 17:29:59 -07:00
Jeff Stieler 3f2ea6bfb6 Add WIP NumberFilter advanced filter component. 2018-12-13 17:29:39 -07:00
Jeff Stieler 7cf157077a Merge pull request woocommerce/woocommerce-admin#1081 from woocommerce/add/currency-input-component
Add `TextControlWithAffixes` component
2018-12-13 15:58:42 -07:00
Albert Juhé Lluveras d9fe77de24 Add autocompleter for customer name 2018-12-13 18:51:48 +01:00
Timmy Crawford 19b209fca4 Add util to packages to fix build. (https://github.com/woocommerce/woocommerce-admin/pull/1079) 2018-12-13 09:06:26 -08:00
Kelly Dwan 87daca2723 Add IDs to affixes, use these in the input’s describedby 2018-12-13 12:04:57 -05:00
Kelly Dwan 8f5861f8b5 Update the examples 2018-12-13 12:04:28 -05:00
Jeff Stieler b8ba4ed16d Fix linting issues with TextControlWithAffixes. 2018-12-13 09:34:46 -07:00
Jeff Stieler 32018506dc Generate TextControlWithAffixes documentation from the component itself. 2018-12-13 09:21:47 -07:00
Jeff Stieler 700f3ad20f Make affix background white and remove wrapping behavior from TextControlWithAffixes. 2018-12-13 09:05:03 -07:00
Jeff Stieler e3be069601 Hook up TextControlWithAffixes to state for interactivity. 2018-12-12 23:15:39 -07:00
Jeff Stieler 44f025f308 Remove Calypso transform focus hack from TextControlWithAffixes (it’s broken here). 2018-12-12 23:11:27 -07:00
renovate[bot] 25ed79669e chore(deps): update babel monorepo to v7.2.0 (https://github.com/woocommerce/woocommerce-admin/pull/981) 2018-12-13 12:55:20 +08:00
Joshua T Flowers ee5b282957 Fix screen reader label IDs (https://github.com/woocommerce/woocommerce-admin/pull/1071) 2018-12-13 09:59:16 +08:00
Jeff Stieler 28a57f2a1d Rework border radius logic for all affix combinations including wrapping cases. 2018-12-12 13:51:25 -07:00
Jeff Stieler 4bfe767ad7 Add TextControlWithAffixes to devdocs listing. 2018-12-12 13:51:25 -07:00
Jeff Stieler aab376a731 Rework TextControlWithAffixes to keep BaseControl at the top of the component tree. 2018-12-12 13:51:25 -07:00
Jeff Stieler 704ee79359 Port over Calypso’s FormTextInputWithAffixes component as TextControlWithAffixes. 2018-12-12 13:51:25 -07:00
Albert Juhé Lluveras 40b00ec7b2 Merge pull request woocommerce/woocommerce-admin#1052 from woocommerce/add/table-header-screenreader-label
Add screen reader labels to table headers which are not buttons
2018-12-12 11:33:44 +01:00
renovate[bot] 9601cd64dd Update dependency core-js to v2.6.0 (https://github.com/woocommerce/woocommerce-admin/pull/1001) 2018-12-12 16:00:36 +08:00
Kevin Killingsworth 62c9a952a1 Table: Add onColumnsChange (https://github.com/woocommerce/woocommerce-admin/pull/1056)
This adds an `onColumnsChange` property which is called when the column
visiblity is toggled on the table. It also cleans up a bit of the
showCols code and fixes an incorrect update in the component update.
2018-12-11 13:34:16 -06:00
Paul Sealock 30289cd240 Update docs and remove reference to internal components 2018-12-11 11:27:32 +13:00
Albert Juhé Lluveras d79b490dda Add Customers Report page (https://github.com/woocommerce/woocommerce-admin/pull/1018)
* Create Customers Report page

* Hide date range filter if dateRangeFilter.show is false

* Rename dateRangeFilter.show to showDatePicker in filters config

* Add correct key 'average_order_value'

* Fix customers autocompleter not working
2018-12-10 13:26:43 -06:00
Albert Juhé Lluveras e8e67e8a76 Add screen reader labels to table headers which are not buttons 2018-12-10 16:45:15 +01:00
Albert Juhé Lluveras 51bc679fd0 Fix customers autocompleter not working 2018-12-10 16:23:34 +01:00
Albert Juhé Lluveras 93a18be2f0 Rename dateRangeFilter.show to showDatePicker in filters config 2018-12-10 16:18:17 +01:00
Jeff Stieler 7291a880eb Update filter component examples with real usage from Orders report.
Also resolves JS errors that were occurring.
2018-12-07 17:07:15 -07:00
Jeff Stieler 71e210d1f8 Fix missing key warning on TableCard devdocs example. 2018-12-07 16:47:30 -07:00
Albert Juhé Lluveras a393ba543b Fix ReportNumber sometimes receiving NaN values (https://github.com/woocommerce/woocommerce-admin/pull/1026)
* Fix ReportNumber sometimes receiving NaN values

* Remove unnecessary utils function

* Destructure summaryData
2018-12-07 15:13:02 -06:00
Albert Juhé Lluveras 44e97caeab Hide date range filter if dateRangeFilter.show is false 2018-12-07 14:19:20 -06:00
Albert Juhé Lluveras 3a9beb238e Add missing comma to chart tooltip label (https://github.com/woocommerce/woocommerce-admin/pull/1021) 2018-12-07 11:47:30 -06:00
Albert Juhé Lluveras d161732c0a Create Customers Report page 2018-12-06 16:25:31 -06:00
Timmy Crawford 46c8518fe1 Add/tax report filters/924 (https://github.com/woocommerce/woocommerce-admin/pull/1017)
* Add comparison filter to tax reports

* Extract tax code function to utils

* Filter tax code strings and add priority
2018-12-06 17:18:46 -05:00
Kevin Killingsworth 8bb3175172 Table Component: Update showcols to use keys (https://github.com/woocommerce/woocommerce-admin/pull/971)
* component/table: Update showcols to use keys

This updates the table component to use keys to keep track of which
columns should be visible instead of column indices. This will be
necessary for keeping track of which columns were selected after a
component has been unmounted and re-mounted again later. (e.g. for
persistence or saving of user preferences)

* components/table: Add changelog entry
2018-12-05 16:30:01 -06:00
Robert Elliott ca28c42ead separate legend styling out 2018-12-05 12:50:07 +02:00
Robert Elliott c9ccc015ca move chart and d3chart components into @woocommerce/components package 2018-12-05 12:50:04 +02:00
Joshua T Flowers 9e1cb88dfa Add filters for order tables column headers/rows (https://github.com/woocommerce/woocommerce-admin/pull/781)
* Add filters for order tables column headers/rows

* Move filters inside rows

* Rename filter constants

* Apply filters directly to rows

* Rename Orders table filter to be more consistent with core

* Filter entire reports table
2018-12-05 09:44:32 +08:00
Kelly Dwan 0045f2b7a4 Bump @woocommerce/components to version 1.2.0 (https://github.com/woocommerce/woocommerce-admin/pull/967)
* Version bump & changelog update

* Roll version back so that lerna updates it

* chore(release): publish

 - @woocommerce/components@1.2.0

* Update packages documentation after trying to follow it
2018-12-03 10:09:16 -05:00
Albert Juhé Lluveras 293d58615d Add screen reader labels to table headers (https://github.com/woocommerce/woocommerce-admin/pull/964)
* Add screen reader labels to tables

* Add missing propType
2018-11-30 14:44:02 -06:00
Kelly Dwan 6e3242c421 Packages – Components: Move proptype-validator utility into src (https://github.com/woocommerce/woocommerce-admin/pull/962)
* Move proptype-validator utility into src

Only src files are transpiled for external use, so requiring this file was breaking my jest tests

* Bump the package version + changelog
2018-11-30 13:19:17 -05:00
Albert Juhé Lluveras 109592ebc9 Don't encode search text in autocompleters before stringifying it (https://github.com/woocommerce/woocommerce-admin/pull/959) 2018-11-29 19:00:51 -06:00
David Levin 3d4ca67f89 Merge pull request woocommerce/woocommerce-admin#958 from woocommerce/update/summary-number-focus
Update/summary number focus
2018-11-29 13:55:45 -08:00
David Levin f2f8ebebe1 Update styles to remove hheight calc and negative margin h4x 2018-11-29 13:49:45 -08:00
Kelly Dwan 062b3fd529 Packages: Add changelogs and documentation (https://github.com/woocommerce/woocommerce-admin/pull/949)
* Add changelogs for latest package releases

* Add lerna instructions

* Add placeholder changelogs for other packages

* Add “working with existing packages"
2018-11-29 16:34:01 -05:00
Paul Sealock 2a4b9bada9 Merge pull request woocommerce/woocommerce-admin#951 from woocommerce/fix/order-statuses-prefix
Remove order statuses "wc-" prefix
2018-11-29 15:01:06 +13:00
Albert Juhé Lluveras d59e5803d3 Hide selected items from autocomplete dropdown (https://github.com/woocommerce/woocommerce-admin/pull/932) 2018-11-28 16:55:11 -06:00
David Levin 4bfea20e56 Ensure all edges of focus use core-grey-dark-300 2018-11-28 13:31:49 -08:00
David Levin f938afe946 Update Summary Focus Styles 2018-11-28 13:14:15 -08:00
Paul Sealock 0ab5c735be Remove order statuses wc- prefix 2018-11-28 15:58:17 +13:00
Kelly Dwan 4b8969acc7 chore(release): publish
- @woocommerce/components@1.1.0
 - @woocommerce/date@1.0.2
 - @woocommerce/navigation@1.1.0
2018-11-27 15:57:27 -05:00
Jonathan Belcher e2faa2fee2 Tag component snapshots (https://github.com/woocommerce/woocommerce-admin/pull/877)
* Tag component snapshots

* Make snapshots better

* Update snapshots
2018-11-27 13:57:52 -05:00
Kelly Dwan 8828345f86 Remove import from local files (https://github.com/woocommerce/woocommerce-admin/pull/939)
These are exported packages, they can’t rely on any local files.
2018-11-27 10:46:22 -08:00
Jonathan Belcher a308fcc830 Adds snapshots for the Split Button component (https://github.com/woocommerce/woocommerce-admin/pull/891)
* Adds snapshots for the Split Button component

* Update snapshots

* Remove duplicate test
2018-11-26 13:44:05 -05:00
Albert Juhé Lluveras 0cbe3034d8 Merge report tables (https://github.com/woocommerce/woocommerce-admin/pull/928)
* Merge report tables

* Remove unnecessary semicolon

* Improve sorting of variables

* Rename props to tableProps in ReportTable
2018-11-26 08:01:20 -06:00
Robert Elliott 24758bc80d squashed commits for chart packaging
expand formatting function to xFormats

adding getTooltipValueFormat

remove old chart examples

remove magic numbers and use variables

refactor getTooltipRowValue

update package-lock

allow function formatters and use @wordpress/elements
2018-11-21 16:10:56 +02:00
Paul Sealock f4c2140258 Update uses of Gutenberg popover for content sizing 2018-11-21 12:00:40 +13:00
Albert Juhé Lluveras 2a95345bb9 Add chartMode property to filters configuration (https://github.com/woocommerce/woocommerce-admin/pull/884)
* Add chartMode property to filters configuration

* Add tests

* Cleanup

* Add chartMode propType to filters
2018-11-20 16:21:47 -06:00
Kelly Dwan 38ef25a272 Add missing dependency from components package (https://github.com/woocommerce/woocommerce-admin/pull/890) 2018-11-20 14:23:42 -05:00
Paul Sealock 38264239fc Merge pull request woocommerce/woocommerce-admin#824 from woocommerce/add/product-detail-link
Add/product detail link
2018-11-20 13:14:34 +13:00
Paul Sealock b7acbd9b2f Add Product Detail link in table 2018-11-20 12:57:36 +13:00
Paul Sealock 0d59998625 Persist chart settings 2018-11-20 12:55:30 +13:00
Albert Juhé Lluveras 9938707970 Add Taxes report table (https://github.com/woocommerce/woocommerce-admin/pull/881)
* Add Taxes report table

* Add taxes autocompleter to Search

* Minor fixes

* Improve @TODO comment explanation
2018-11-19 09:55:15 -06:00
Kelly Dwan 741f5cc6c6 chore(release): publish
- @woocommerce/components@1.0.1
 - @woocommerce/date@1.0.1
2018-11-16 15:31:11 -05:00
Kelly Dwan 87cf118878 Remove imports from file that doesn’t exist in packages (https://github.com/woocommerce/woocommerce-admin/pull/876) 2018-11-16 14:31:20 -05:00
renovate[bot] 098b24e99e fix(deps): update dependency @babel/runtime-corejs2 to v7.1.5 (https://github.com/woocommerce/woocommerce-admin/pull/865) 2018-11-16 09:14:34 -05:00
renovate[bot] 97faa52909 fix(deps): update dependency d3-array to v2 (https://github.com/woocommerce/woocommerce-admin/pull/872) 2018-11-16 09:13:50 -05:00
Kelly Dwan 94200cbbc1 chore(release): publish
- @woocommerce/components@1.0.0-alpha.1
 - @woocommerce/csv-export@1.0.0-alpha.1
 - @woocommerce/currency@1.0.0-alpha.1
 - @woocommerce/date@1.0.0-alpha.1
 - @woocommerce/navigation@1.0.0-alpha.1
2018-11-15 18:31:20 -05:00
Kelly Dwan 2a9cb6509b Build: Move components to packages dir (https://github.com/woocommerce/woocommerce-admin/pull/804)
* Move components to packages folder

* Update documentation generator to handle packages/components and client/components

* Update component locations

* Update CSS build process

* Remove react-dates css, this is already included by gutenberg

* Fix CSS style - single quotes

* Fix incorrect imports

* Update package-lock with new dependencies

* Update component locations for devdocs

* Fix location of tests
2018-11-15 13:16:23 -05:00
Paul Sealock c809fa6cb9 Apply onQueryChange to more than just 'filter' 2018-11-14 09:56:39 +13:00
Robert Elliott bd1997b725 Merge pull request woocommerce/woocommerce-admin#785 from woocommerce/add/chart-63day-x1month-x2year
Component - chart: more than 9 weeks of ticks change xFormat to months & x2Format to yrs
2018-11-13 10:16:01 +02:00
Kelly Dwan 89cee0df90 Build: Move filter code to the navigation package (https://github.com/woocommerce/woocommerce-admin/pull/803)
* Move filter code to the navigation package

- Moves filter-related code to navigation, so it can be shared between components and the app
- Fixes spelling of “flatten”
- Update README docs with new functions

* Use `get` to prevent errors if options is not an array/is empty

* Update documentation and tests
2018-11-12 11:17:18 -05:00
renovate[bot] cbcdf9ba78 Update babel monorepo to v7.1.5 (https://github.com/woocommerce/woocommerce-admin/pull/789) 2018-11-07 12:04:34 -05:00
Kelly Dwan 8af82f3dee Build: Move `lib/csv` to packages (https://github.com/woocommerce/woocommerce-admin/pull/756)
* Move CSV to packages

* Update CSV imports

* Add some basic usage documentation

* Add csv lib to the enqueued assets

* Change name to `csv-export`

* Update webpack build process to allow for package names with dashes

* Fix capitalization

* Update readme with docs extracted from jsdoc

* Fix merge conflict commit 😣

* Check that generateCSVFileName is called with correct params
2018-11-06 16:53:22 -05:00
Robert Elliott d59594c4f6 at more than 9 weeks of ticks change xFormat to months and x2Format to years 2018-11-06 16:02:16 +02:00
Kelly Dwan d27cb26ef7 Build: Move `lib/nav-utils` and `lib/history` to `@woocommerce/navigation` (https://github.com/woocommerce/woocommerce-admin/pull/763)
* Move nav-utils and history to new package

* Update config to build and use new navigation package

* Update all imports to use new navigation package

* Remove unnecessary README

* Update nav-utils path
2018-11-05 16:02:04 -05:00
renovate[bot] 3ef218b0bf Update wordpress monorepo (https://github.com/woocommerce/woocommerce-admin/pull/745) 2018-11-03 13:23:57 -04:00
Kelly Dwan f62537fc17 Try: Add Lerna to split out utility packages (https://github.com/woocommerce/woocommerce-admin/pull/678)
* Add lerna & GB package-building script

* Move currency library to lerna module

* Update lerna config

* Add publish commands

* Add currency as an faux-external module

* Add separate command to build just core files

* Update dependency path

* Update build script to build all packages into `dist`

* Add packages to the jest test setup

* Move date library to packages

* Update imports to use @woocommerce/date

* Output wcSettings definition before any scripts are output

Fixes issues where wc-dates lib relies on settings object

* Add the build step into travis

* Update jest config to dynamically get package paths

* Update package postcss config to match wc-admin’s main config

* Add combined watch scripts for package+app, add a `clean` command to clean up old build files

* Ignore PHPCS error (leave todo message to fix)

* Concat files with a space, fix issue where all files join in one continuous string and fail the check
2018-10-30 14:57:48 -04:00